From owner-svn-ports-all@FreeBSD.ORG  Fri May 30 10:03:17 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id EA0397DF;
 Fri, 30 May 2014 10:03:17 +0000 (UTC)
Received: from mail-yh0-x235.google.com (mail-yh0-x235.google.com
 [IPv6:2607:f8b0:4002:c01::235])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 811F82525;
 Fri, 30 May 2014 10:03:17 +0000 (UTC)
Received: by mail-yh0-f53.google.com with SMTP id i57so1351826yha.12
 for <multiple recipients>; Fri, 30 May 2014 03:03:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date:message-id:subject
 :from:to:cc:content-type;
 bh=Z3T958JRk4ocDOBZ5kuupbPI7xtWYjzbRDM+GQm/mXQ=;
 b=ji/qofUuafLDVuQBdZL1Mt6JQaBWkyvVv1m6uPgn3Ozyudy27aBcOCT/M9GLyRAhAn
 EaE9dOaPfRqJjCbsgvUvLi0EmjcbJc7nRdlxP0Sg2xb8mez2fX6UocDYUpGLzRScaYvV
 FIlEou7fs2fCGmaE237d8c48/nyY0vDFbdZqllNcotrluN7SDhfzMDO27oeidBc+LVeK
 Q0bsvnMjOMO7v1hVHs1IlIvmwAUkbBYxtlXXEMD8blIIppI0xEoBAwyDybg0+knGZqzS
 Fg5xbvi5fnihNHhuHbrq/gQKRuhQ8rUms1yGl4dqnNHzScpovOpeyLdXjz0jBpP4bN9j
 g0Cw==
MIME-Version: 1.0
X-Received: by 10.236.131.42 with SMTP id l30mr19390906yhi.130.1401444196707; 
 Fri, 30 May 2014 03:03:16 -0700 (PDT)
Sender: antoine.brodin.freebsd@gmail.com
Received: by 10.170.50.80 with HTTP; Fri, 30 May 2014 03:03:16 -0700 (PDT)
In-Reply-To: <53885290.20102@marino.st>
References: <201405300923.s4U9N2SU054380@svn.freebsd.org>
 <CAALwa8k-48YpPwA2qiMw+fwmdE4QJ=JHBkv=tSv2XUpWAPAFKA@mail.gmail.com>
 <53885290.20102@marino.st>
Date: Fri, 30 May 2014 12:03:16 +0200
X-Google-Sender-Auth: uTnLW-k5CdNLg_XUwe8NzPlO2Io
Message-ID: <CAALwa8nX_O7nsFix1eWA7D4dpVu3z9erwG3_2JAJQCXYaQjReg@mail.gmail.com>
Subject: Re: svn commit: r355806 - head/x11-themes/clearlooks-themes-extras
From: Antoine Brodin <antoine@FreeBSD.org>
To: John Marino <marino@freebsd.org>
Content-Type: text/plain; charset=UTF-8
Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>,
 "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>,
 "ports-committers@freebsd.org" <ports-committers@freebsd.org>
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 30 May 2014 10:03:18 -0000

On Fri, May 30, 2014 at 11:42 AM, John Marino <freebsd.contact@marino.st> wrote:
> On 5/30/2014 11:31, Antoine Brodin wrote:
>> On Fri, May 30, 2014 at 11:23 AM, John Marino <marino@freebsd.org> wrote:
>>> Author: marino
>>> Date: Fri May 30 09:23:02 2014
>>> New Revision: 355806
>>> URL: http://svnweb.freebsd.org/changeset/ports/355806
>>> QAT: https://qat.redports.org/buildarchive/r355806/
>>>
>>> Log:
>>>   x11-themes/clearlooks-themes-extras: Stage support+
>>>
>>>   In addition to supporting stage, the unnecessarily custom extraction
>>>   target was replaced with NO_WRKSUBDIR.
>>>
>>> Modified:
>>>   head/x11-themes/clearlooks-themes-extras/Makefile
>>
>> Hi,
>>
>> This looks wrong:
>> - creates a directory outside of stagedir during install
>
> I missed "@${MKDIR} ${THEME_DIR}" => "@${MKDIR} ${STAGEDIR}${THEME_DIR}"
> unfortunately redports didn't complain
>
>
>> - use of NO_WRKSUBDIR + cd ${WRKSRC} && ${FIND} . ... is usually harmfull
>
> why?  I would have used COPYTREE or something myself but I don't see
> anything immediately wrong with this.

Run "make check-plist" or "make check-orphans" and you will see that
unexpected files end up in stagedir.

Cheers,

Antoine