From owner-freebsd-current@FreeBSD.ORG Thu May 3 20:00:05 2012 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E2445106564A for ; Thu, 3 May 2012 20:00:05 +0000 (UTC) (envelope-from maksim.yevmenkin@gmail.com) Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com [209.85.160.54]) by mx1.freebsd.org (Postfix) with ESMTP id AD1FB8FC12 for ; Thu, 3 May 2012 20:00:05 +0000 (UTC) Received: by pbbro2 with SMTP id ro2so3200599pbb.13 for ; Thu, 03 May 2012 13:00:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=r6qLBpBk7YeBaJgbcJhmTn0zu/ITc/6X6SXyGufNjjk=; b=W7jQ+6zqvP/Wepxnw2GgXCzCygkRymhdHWlcH++q6xggutWhcrmqnAy+hHPZD+IO/Y LOUtYP5qeicYmb8vxMjrP5yXJsFIha1Baft6tjBynnabGMKUlnjfa893VkrLxSJO+8KA LIns2kisBpW2xCqiAbA98A+ltdVoVBcGAwL/G3UTzxlnv8stbA5IxMDyehglXdvt1ZRU FPXPfAeP5dAU+6JlzgJ/OlnlfkCrheYHpaLK31tH4dgEU0EKSZh9bEfW7VhTaqox/cDQ cNOUjdQyCyGqUH0e0IcIrYnAKlYAIRvsPn/UQrrLOJ4KwTo153BffXg1UL0uHsnL2Qul MHMA== MIME-Version: 1.0 Received: by 10.68.202.167 with SMTP id kj7mr11095783pbc.9.1336075205555; Thu, 03 May 2012 13:00:05 -0700 (PDT) Received: by 10.68.2.74 with HTTP; Thu, 3 May 2012 13:00:05 -0700 (PDT) Date: Thu, 3 May 2012 13:00:05 -0700 Message-ID: From: Maksim Yevmenkin To: current@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 Cc: Subject: [patch]: RFC changing order for khelp modules X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2012 20:00:06 -0000 hello, would anyone object to the following patch? == --- sys/module_khelp.h (revision 582) +++ sys/module_khelp.h (working copy) @@ -83,7 +83,7 @@ .priv = &kmd_##hname \ }; \ DECLARE_MODULE(hname, h_##hname, SI_SUB_PROTO_IFATTACHDOMAIN, \ - SI_ORDER_ANY); \ + SI_ORDER_MIDDLE); \ MODULE_VERSION(hname, version) #define KHELP_DECLARE_MOD_UMA(hname, hdata, hhooks, version, size, ctor, dtor) \ @@ -102,7 +102,7 @@ .priv = &kmd_##hname \ }; \ DECLARE_MODULE(hname, h_##hname, SI_SUB_PROTO_IFATTACHDOMAIN, \ - SI_ORDER_ANY); \ + SI_ORDER_MIDDLE); \ MODULE_VERSION(hname, version) == the issue i stumbled upon is that when i compile in all available tcp congestion control algorithms into the kernel (instead of using them as modules) a couple of those fail to initialize and register because they fail to find h_ertt khelp module (which is also complied in) thanks, max