From owner-freebsd-current@FreeBSD.ORG  Thu Mar  9 20:16:15 2006
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@freebsd.org
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5158B16A420
	for <freebsd-current@freebsd.org>; Thu,  9 Mar 2006 20:16:15 +0000 (GMT)
	(envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A907543D46
	for <freebsd-current@freebsd.org>; Thu,  9 Mar 2006 20:16:14 +0000 (GMT)
	(envelope-from imp@bsdimp.com)
Received: from localhost (localhost.village.org [127.0.0.1] (may be forged))
	by harmony.bsdimp.com (8.13.3/8.13.3) with ESMTP id k29KFrj0014030;
	Thu, 9 Mar 2006 13:15:54 -0700 (MST) (envelope-from imp@bsdimp.com)
Date: Thu, 09 Mar 2006 13:16:00 -0700 (MST)
Message-Id: <20060309.131600.13027338.imp@bsdimp.com>
To: ai@bmc.brk.ru
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <20060309084500.44e5b8ae.ai@bmc.brk.ru>
References: <20060309084500.44e5b8ae.ai@bmc.brk.ru>
X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0
	(harmony.bsdimp.com [127.0.0.1]);
	Thu, 09 Mar 2006 13:15:54 -0700 (MST)
Cc: freebsd-current@freebsd.org
Subject: Re: exca(4) caused panic
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Mar 2006 20:16:15 -0000

In message: <20060309084500.44e5b8ae.ai@bmc.brk.ru>
            Artemiev Igor <ai@bmc.brk.ru> writes:
: 
: With 1.23 revision /sys/dev/exca/exca.c my notebook going to the panic,
: when an pccard inserted. That patch fixed this problem:
: 
: --- sys/dev/exca/exca.c.orig Thu Mar  9 08:26:13 2006
: +++ sys/dev/exca/exca.c  Thu Mar  9 08:26:44 2006
: @@ -179,11 +179,11 @@
:     struct mem_map_index_st *map;
:     struct pccard_mem_handle *mem;
:     uint32_t offset;
: -   int mem8 = (mem->kind == PCCARD_A_MEM_ATTR);
: -   mem8 = 1;
: +   int mem8; 
: 
:     map = &mem_map_index[win];
:     mem = &sc->mem[win];
: +   mem8 = (mem->kind == PCCARD_A_MEM_ATTR);
:     offset = ((mem->cardaddr >> EXCA_CARDMEM_ADDRX_SHIFT) -
:       (mem->addr >> EXCA_SYSMEM_ADDRX_SHIFT)) & 0x3fff;
:     exca_putb(sc, map->sysmem_start_lsb,
: 

I wonder why notebook doesn't panic.  None-the-less, I've committed a
fix for this to head.  Thanks for the catch.

Warner