From owner-svn-ports-all@FreeBSD.ORG  Fri May 30 11:13:24 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 3D3138CB;
 Fri, 30 May 2014 11:13:24 +0000 (UTC)
Received: from ravenloft.kiev.ua (ravenloft.kiev.ua [94.244.131.95])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id F41612A44;
 Fri, 30 May 2014 11:13:23 +0000 (UTC)
Date: Fri, 30 May 2014 14:13:21 +0300
From: Alex Kozlov <ak@FreeBSD.org>
To: John Marino <marino@FreeBSD.org>
Subject: Re: svn commit: r355815 - head/textproc/no-hunspell
Message-ID: <20140530111321.GA31400@ravenloft.kiev.ua>
References: <201405301014.s4UAEfYE077850@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201405301014.s4UAEfYE077850@svn.freebsd.org>
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 30 May 2014 11:13:24 -0000

On Fri, May 30, 2014 at 10:14:41AM +0000, John Marino wrote:
> Author: marino
> Date: Fri May 30 10:14:40 2014
> New Revision: 355815
> URL: http://svnweb.freebsd.org/changeset/ports/355815
> QAT: https://qat.redports.org/buildarchive/r355815/
> 
> Log:
>   textproc/no-hunspell: use explicit UNZIP_CMD (requires infozip)
>   
>   The tool needed for extract is zip.  However UNZIP_CMD explicitly refers
>   to zipinfo, and UNZIP_NATIVE_CMD isn't available on DragonFly.  To future-
>   proof the port, convert EXTRACT_CMD and EXTRACT_BEFORE_ARGS to UNZIP_CMD
>   and the default zip extraction args.  The (small) price is a new
>   dependency on infozip.  Covered by general infrastructure blanket.
Please revert this. Previous version worked on DragonFly without infozip dependency.
Also, if automatic EXTRACT_CMD selection will be implemented, I'll fix all edge
cases, so there is no need to change ports to make them 'future-proof'.

p.s. Afaik, UNZIP_CMD doesn't refers to zipinfo.


> Modified:
>   head/textproc/no-hunspell/Makefile
> 
> Modified: head/textproc/no-hunspell/Makefile
> ==============================================================================
> --- head/textproc/no-hunspell/Makefile	Fri May 30 10:13:39 2014	(r355814)
> +++ head/textproc/no-hunspell/Makefile	Fri May 30 10:14:40 2014	(r355815)
> @@ -12,7 +12,7 @@ DIST_SUBDIR=	${PORTNAME}
>  MAINTAINER=	office@FreeBSD.org
>  COMMENT=	Norwegian (Nynorsk and Bokmaal) hunspell dictionaries
>  
> -USES=		zip
> +USES=		zip:infozip
>  NO_BUILD=	yes
>  
>  PLIST_FILES=	%%DATADIR%%/nb_NO.aff \
> @@ -23,8 +23,8 @@ PLIST_DIRSTRY=	%%DATADIR%%
>  
>  post-extract:
>  	@${MKDIR} ${WRKSRC}
> -	@${EXTRACT_CMD} ${EXTRACT_BEFORE_ARGS} ${WRKDIR}/nb_NO.zip -d ${WRKSRC}
> -	@${EXTRACT_CMD} ${EXTRACT_BEFORE_ARGS} ${WRKDIR}/nn_NO.zip -d ${WRKSRC}
> +	@${UNZIP_CMD} -qo ${WRKDIR}/nb_NO.zip -d ${WRKSRC}
> +	@${UNZIP_CMD} -qo ${WRKDIR}/nn_NO.zip -d ${WRKSRC}
>  
>  do-install:
>  	${MKDIR} ${STAGEDIR}${DATADIR}/


-- 
Alex