From owner-freebsd-current@FreeBSD.ORG Mon Feb 2 02:38:44 2015 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E3F0DE7A for ; Mon, 2 Feb 2015 02:38:44 +0000 (UTC) Received: from sasl.smtp.pobox.com (pb-smtp1.int.icgroup.com [208.72.237.35]) by mx1.freebsd.org (Postfix) with ESMTP id B40418CB for ; Mon, 2 Feb 2015 02:38:43 +0000 (UTC) Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id C779F3572D for ; Sun, 1 Feb 2015 21:38:37 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=message-id :date:from:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; s=sasl; bh=Wle0+J1Oak9g AVYTkamD+gSpG14=; b=BUVZFdlOMo5VAkdhdsioLSM0smykBcG+PGQaEE8783Dj 62GDubLFHDyy7VahebtnKCekxcs5tVOQXezggHz6lB6n/0B8msNyTZuDbyKWa/Hn LdDTkTeDI+/u/rP6NOIonwL1gaTwLH6BcWLfL2yeVEH4T0rU2GcfhkSLnaBtYnY= Received: from pb-smtp1.int.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id BDBF93572A for ; Sun, 1 Feb 2015 21:38:37 -0500 (EST) Received: from [192.168.1.103] (unknown [73.164.1.204]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 5AAE435729 for ; Sun, 1 Feb 2015 21:38:36 -0500 (EST) Message-ID: <54CEE325.4040903@badgerio.us> Date: Sun, 01 Feb 2015 20:38:29 -0600 From: Eric Badger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: freebsd-current@freebsd.org Subject: Re: Filepaths in VM map for tmpfs files References: <54CCEFAB.9040406@badgerio.us> <20150131153621.GH42409@kib.kiev.ua> In-Reply-To: <20150131153621.GH42409@kib.kiev.ua> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Pobox-Relay-ID: 9706C262-AA84-11E4-BC6A-7BA29F42C9D4-46178211!pb-smtp1.pobox.com X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Feb 2015 02:38:45 -0000 On 01/31/2015 09:36 AM, Konstantin Belousov wrote: > First, shouldn't the kve_type changed to KVME_TYPE_VNODE as well ? My thinking is no, because KVME_TYPE_SWAP is in fact the correct type; I'd opine that it is better to be transparent than make it look like there is an OBJT_VNODE object there. It may be that some programs would be confused by VNODE info returned on a SWAP type mapping, though I know that dtrace handles it OK. > Second, note that it is possible that the vnode is recycled, so > OBJ_TMPFS flag is cleared for tmpfs swap object. The OBJ_TMPFS_NODE > flag is still set then. I am not sure what to do in this case, > should the type changed to KVME_TYPE_VNODE still, but kve_vn_* > fields left invalid ? I think if we changed to KVME_TYPE_VNODE in some cases, it should be done in all cases, even if the vnode has been recycled (but leave vp == NULL in that case). Though if it is left as KVME_TYPE_SWAP, then that concern goes away on its own. Eric