From owner-cvs-src@FreeBSD.ORG Thu Mar 23 22:58:42 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E296416A422; Thu, 23 Mar 2006 22:58:42 +0000 (UTC) (envelope-from kris@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8A33043D48; Thu, 23 Mar 2006 22:58:42 +0000 (GMT) (envelope-from kris@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k2NMwgmD018181; Thu, 23 Mar 2006 22:58:42 GMT (envelope-from kris@repoman.freebsd.org) Received: (from kris@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k2NMwgRN018180; Thu, 23 Mar 2006 22:58:42 GMT (envelope-from kris) Message-Id: <200603232258.k2NMwgRN018180@repoman.freebsd.org> From: Kris Kennaway Date: Thu, 23 Mar 2006 22:58:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/nfsclient nfs_socket.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Mar 2006 22:58:43 -0000 kris 2006-03-23 22:58:42 UTC FreeBSD src repository Modified files: sys/nfsclient nfs_socket.c Log: Fix a bug in the NFS/TCP retransmission path. The bug was that earlier, if a request was retransmitted, we would do subsequent retransmits every 10 msecs. This can cause data corruption under moderate loads by reordering operations as seen by the client NFS attribute cache, and on the server side when the retransmission occurs after the original request has left the duplicate cache, since the operation will be committed for a second time. Further work on retransmission handling is needed (e.g. they are still being done sent too often since they are scaled by HZ, and the size of the dup cache is too small and easily overwhelmed on busy servers). Submitted by: mohans Revision Changes Path 1.137 +1 -0 src/sys/nfsclient/nfs_socket.c