From owner-freebsd-bugs@FreeBSD.ORG  Wed Jan 12 21:50:26 2005
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B9B0716A4CE
	for <freebsd-bugs@hub.freebsd.org>;
	Wed, 12 Jan 2005 21:50:26 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9F63B43D53
	for <freebsd-bugs@hub.freebsd.org>;
	Wed, 12 Jan 2005 21:50:26 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.1/8.13.1) with ESMTP id j0CLoQGF016554
	for <freebsd-bugs@freefall.freebsd.org>; Wed, 12 Jan 2005 21:50:26 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.1/8.13.1/Submit) id j0CLoQhZ016553;
	Wed, 12 Jan 2005 21:50:26 GMT
	(envelope-from gnats)
Date: Wed, 12 Jan 2005 21:50:26 GMT
Message-Id: <200501122150.j0CLoQhZ016553@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Dan Nelson <dnelson@allantgroup.com>
Subject: Re: bin/76169: [PATCH] Add PAM support to cvs pserver
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Dan Nelson <dnelson@allantgroup.com>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Jan 2005 21:50:26 -0000

The following reply was made to PR bin/76169; it has been noted by GNATS.

From: Dan Nelson <dnelson@allantgroup.com>
To: Giorgos Keramidas <keramida@ceid.upatras.gr>
Cc: bug-followup@freebsd.org
Subject: Re: bin/76169: [PATCH] Add PAM support to cvs pserver
Date: Wed, 12 Jan 2005 15:48:21 -0600

 In the last episode (Jan 12), Giorgos Keramidas said:
 > On 2005-01-12 12:15, Dan Nelson <dnelson@allantgroup.com> wrote:
 > > Most of the base services have been PAM-ified, but cvs is a notable
 > > exception.  CVS 1.12 will have PAM support, but I don't know when 1.12
 > > will be declared stable. The following patch is based on Steve
 > > McIntyre's 1.11 patch at
 > > http://ccvs.cvshome.org/issues/show_bug.cgi?id=44 .
 > 
 > CVS is contrib software, so I don't know if we can just pull the
 > files off the vendor branch so easily.
 
 I think server.c is already off the vendor branch.
 
 >  But I noticed a small nit, that you may want to fix in the diff:
 > 
 > > --- gnu/usr.bin/cvs/cvs/Makefile	6 Aug 2004 07:27:03 -0000	1.48
 > > +++ gnu/usr.bin/cvs/cvs/Makefile	5 Jan 2005 18:25:50 -0000
 > :
 > >  DPADD=	${LIBCVS} ${LIBDIFF} ${LIBGNUREGEX} ${LIBMD} ${LIBCRYPT} ${LIBZ}
 > > -LDADD=	${LIBCVS} ${LIBDIFF} -lgnuregex -lmd -lcrypt -lz
 > > +LDADD=	${LIBCVS} ${LIBDIFF} -lgnuregex -lmd -lcrypt -lz -lpam
 > 
 > Adding libraries in LDADD should also update DPADD, IIRC.
 > The fix is simple: add ${LIBPAM} to DPADD too.
 
 Yes.  Updated copy at http://dan.allantgroup.com/FreeBSD/cvs.diff
 
 -- 
 	Dan Nelson
 	dnelson@allantgroup.com