From owner-svn-src-projects@FreeBSD.ORG Thu Jul 9 08:35:47 2009 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5FFD9106566C; Thu, 9 Jul 2009 08:35:47 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: from mail-ew0-f224.google.com (mail-ew0-f224.google.com [209.85.219.224]) by mx1.freebsd.org (Postfix) with ESMTP id B08738FC15; Thu, 9 Jul 2009 08:35:46 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: by ewy24 with SMTP id 24so450976ewy.43 for ; Thu, 09 Jul 2009 01:35:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:from:to :in-reply-to:content-type:content-transfer-encoding:mime-version :subject:date:references:x-mailer; bh=5UyEzGlv06INayGhdxCR+z2j8Ze8zort8oJoH1DUdng=; b=kZPk1K23+UmnFWyIPKKrc7bTsZY6CpvTqLfOpqNcIkRooIgWtlMBiQbiayAZ3MVyWY q77VmTDfv7v3Jh0JaSwMr1l5G1AOovJII+LKvXe7enHzLZ9m/eyIRyf8xPTvZZxn91ge 4csPKUZRevts4zR8g7cyiBH0Zv3SBMl7fL9/A= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:from:to:in-reply-to:content-type :content-transfer-encoding:mime-version:subject:date:references :x-mailer; b=l3setFwyludFCeJkGFgpRSZ0yXfAqb6XxQpioxtZSUWu12jEvgC7ReQWCUS+9hwHU2 1fNBC5n8N5A1RumYqUcOpJ6M1pyVd0D4YeIMcgAUPsdfqoBwGs+aYlW6UJY6DfXCbwN9 ATGi1wXx9zjeGeKAEZ6Y916z82ag3sF/a0yY0= Received: by 10.210.71.13 with SMTP id t13mr608179eba.57.1247128545473; Thu, 09 Jul 2009 01:35:45 -0700 (PDT) Received: from omega.lan (bl6-157-190.dsl.telepac.pt [82.155.157.190]) by mx.google.com with ESMTPS id 23sm4689009eya.6.2009.07.09.01.35.43 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 09 Jul 2009 01:35:44 -0700 (PDT) Message-Id: From: Rui Paulo To: Bruce Evans , src-committers@freebsd.org, svn-src-projects@freebsd.org In-Reply-To: Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v935.3) Date: Thu, 9 Jul 2009 09:35:42 +0100 References: <200907081604.n68G4F0g056097@svn.freebsd.org> <20090709042523.B46144@delplex.bde.org> X-Mailer: Apple Mail (2.935.3) Cc: Subject: Re: svn commit: r195463 - projects/mesh11s/sys/net80211 X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jul 2009 08:35:47 -0000 On 9 Jul 2009, at 09:31, Rui Paulo wrote: > On 8 Jul 2009, at 19:30, Bruce Evans wrote: > >> On Wed, 8 Jul 2009, Rui Paulo wrote: >> >>> Log: >>> Revert 195460: gcc does evil things without __packed. >> >> Oops, I asked if __packed was really spurious before seeing this. >> >> gcc does evil things with __packed (starting with it not being a >> syntax >> error). >> >> Did it only break on arm? > > I didn't have a chance to try other architectures. But possibly, yes. > For example, sizeof(meshconf_ie) is 23 but, on arm and without > __packed, it gave me 26 IIRC. Actually, sizeof(meshconf_ie) should be 25, but on arm sizeof(meshconf_ie) == 28 (next multiple of 4). We then decrement 2 from the sizeof in the code, so this gives 26 (the correct answer would be 23, of course). -- Rui Paulo