From owner-freebsd-current  Mon Jul 10 17:43:45 1995
Return-Path: current-owner
Received: (from majordom@localhost)
          by freefall.cdrom.com (8.6.10/8.6.6) id RAA28064
          for current-outgoing; Mon, 10 Jul 1995 17:43:45 -0700
Received: from gndrsh.aac.dev.com (gndrsh.aac.dev.com [198.145.92.241])
          by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id RAA28058
          for <freebsd-current@freebsd.org>; Mon, 10 Jul 1995 17:43:42 -0700
Received: (from rgrimes@localhost) by gndrsh.aac.dev.com (8.6.11/8.6.9) id RAA14768; Mon, 10 Jul 1995 17:43:24 -0700
From: "Rodney W. Grimes" <rgrimes@gndrsh.aac.dev.com>
Message-Id: <199507110043.RAA14768@gndrsh.aac.dev.com>
Subject: Re: gnu/usr.bin/texinfo/Makefile.inc
To: rgrimes@gndrsh.aac.dev.com (Rodney W. Grimes)
Date: Mon, 10 Jul 1995 17:43:24 -0700 (PDT)
Cc: joerg_wunsch@uriah.heep.sax.de, roberto@keltia.freenix.fr,
        freebsd-current@freebsd.org
In-Reply-To: <199507110036.RAA14743@gndrsh.aac.dev.com> from "Rodney W. Grimes" at Jul 10, 95 05:36:15 pm
X-Mailer: ELM [version 2.4 PL24]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Content-Length: 2312      
Sender: current-owner@freebsd.org
Precedence: bulk

> 
> > 
> > As Rodney W. Grimes wrote:
> > > 
> > > > 
> > > > Jörg, why are you forcing -O2 in this file for all of texinfo's utilities ?
> > 
> > > > +CFLAGS+= -O2 -pipe
> > > 
> > > You confused the heck out of me with this one, this is a modification on
> > > some machine some place, this modification is part of a recent commit,
> > > which I did not have pulled out in my source tree.
> > > 
> > > cvs diff -u -r1.2 -r1.3 showed me it was added recently.  This should
> > > not be there unless there is a VERY good reason for it.  Either way
> > > the -pipe must die, that really kills small machines compiling.
> > 
> > The -pipe went in by accident.  After fiddling a bit around with it, i
> > didn't find an easy way to fetch the setting out of /etc/make.conf
> > without breaking the whole (and ugly) make mechanism of texinfo.  The
> > previous state of the art has been _no_ optimization at all, which i
> > considered bogus.
> 
> Other than texinfo/misc/Makefile these all include bsd.prog.mk which
> should already be handling the /etc/make.conf stuff.
> 
> The real question now is why do all these makefiles explicitly null
> out CFLAGS then add a bunch of defines to it???  That should be done
> with setting COPTS, not CFLAGS!!!
> 
> > If anybody knows a better solution, i'm willing to use it.  Otherwise
> > i would simply go and kill the -pipe.
> 
> Use COPTS instead of CFLAGS in the bloody makefiles, CFLAGS is global
> to the tree, COPTS is private to a particular directory.

And a few greps over the Makefiles for the whole source tree show that
this has degenerated badly and reading /usr/share/mk/bsd.README says that
CFLAGS is not even suppose to be visible (ie, it is not mentioned, only
COPTS is :-( :-( :-().

Some one please go fix texinfo's Makefiles to not have one bloddy 
refererence to CFLAGS and use COPTS as it should and I will look at
fixing the whole of the rest of the tree.

> > (Btw., i've not seen Ollivier's message at all.)
> 
> :-(.
> 
> 
> 
> -- 
> Rod Grimes                                      rgrimes@gndrsh.aac.dev.com
> Accurate Automation Company                 Reliable computers for FreeBSD
> 


-- 
Rod Grimes                                      rgrimes@gndrsh.aac.dev.com
Accurate Automation Company                 Reliable computers for FreeBSD