Date: Sun, 30 Jul 2023 00:35:13 +0200 From: Rodrigo Osorio <rodrigo@FreeBSD.org> To: Daniel Engberg <diizzy@FreeBSD.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 9c24afe97b74 - main - sysutils/sispmctl: New port to manage EnerGenie and Gembird USB controlled power strips Message-ID: <80629414-93ef-96c4-0742-df87795ecbda@FreeBSD.org> In-Reply-To: <2841fe66cdc354b102b25e168bc81f96@pyret.net> References: <202307291947.36TJlX9a006964@gitrepo.freebsd.org> <2841fe66cdc354b102b25e168bc81f96@pyret.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Daniel, Sorry for this terrible commit. On 29/07/23 22:25, Daniel Engberg wrote: > Hi, > > There seems to be some issues as it fails to build, patches don't apply. > ===> FAILED to apply cleanly FreeBSD patch(es) patch-src_web2_index.html I disable the webserver capability of the tool so all patches related to www can be removed just like plist entries. dos2unix is also not required anymore. > A few other things that I noticed, > Why is USES= autoreconf needed? Agree. removed > COMMENT should be fixed Fixed > Consider using DISTVERSION instead of PORTVERSION as recommended by > Porters Handbook > Do we really need to install a static library? Not really, so I disable the static libraries build > Consider using framework variables for pkg-plist, %%PORTDOCS%%%%DOCSDIR%% > Missing rc.d script for webserver component (disable it)? I disable the webserver capability... > > Best regards, > Daniel Regards Rodrigo
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?80629414-93ef-96c4-0742-df87795ecbda>