From owner-cvs-all@FreeBSD.ORG Thu Mar 25 15:10:09 2010 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EBBA5106566B; Thu, 25 Mar 2010 15:10:09 +0000 (UTC) (envelope-from rnoland@FreeBSD.org) Received: from gizmo.2hip.net (gizmo.2hip.net [64.74.207.195]) by mx1.freebsd.org (Postfix) with ESMTP id 957DF8FC1A; Thu, 25 Mar 2010 15:10:09 +0000 (UTC) Received: from [10.170.20.44] (nat-170-141-177-44.tn.gov [170.141.177.44]) (authenticated bits=0) by gizmo.2hip.net (8.14.3/8.14.3) with ESMTP id o2PF9wb1077575 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 25 Mar 2010 11:10:07 -0400 (EDT) (envelope-from rnoland@FreeBSD.org) Message-ID: <4BAB7CC4.6050301@FreeBSD.org> Date: Thu, 25 Mar 2010 10:09:56 -0500 From: Robert Noland Organization: FreeBSD User-Agent: Thunderbird 2.0.0.19 (X11/20090218) MIME-Version: 1.0 To: Marius Strobl References: <201003220505.o2M556oW060661@repoman.freebsd.org> <20100323215506.GA19561@alchemy.franken.de> <1269514777.8175.3.camel@balrog.2hip.net> <20100325125012.GD20888@alchemy.franken.de> <20100325142237.1ceae7db@ernst.jennejohn.org> <20100325133934.GE20888@alchemy.franken.de> In-Reply-To: <20100325133934.GE20888@alchemy.franken.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=3.8 required=5.0 tests=AWL, BAYES_00, FH_DATE_PAST_20XX, RDNS_DYNAMIC,SPF_SOFTFAIL autolearn=no version=3.2.5 X-Spam-Level: *** X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on gizmo.2hip.net Cc: Gary Jennejohn , Mark Linimon , nork@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org, cvs-ports@freebsd.org Subject: Re: cvs commit: ports/graphics/dri Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Mar 2010 15:10:10 -0000 Marius Strobl wrote: > On Thu, Mar 25, 2010 at 02:22:37PM +0100, Gary Jennejohn wrote: >> On Thu, 25 Mar 2010 13:50:12 +0100 >> Marius Strobl wrote: >> >>> On Thu, Mar 25, 2010 at 05:59:37AM -0500, Robert Noland wrote: >>>> On Tue, 2010-03-23 at 16:55, Marius Strobl wrote: >>>>> On Mon, Mar 22, 2010 at 05:05:06AM +0000, Mark Linimon wrote: >>>>>> linimon 2010-03-22 05:05:06 UTC >>>>>> >>>>>> FreeBSD ports repository >>>>>> >>>>>> Modified files: >>>>>> graphics/dri Makefile >>>>>> Log: >>>>>> Mark as broken on ia64 and sparc64: fails to install. >>>>>> >>>>>> Hat: portmgr >>>>>> >>>>> The following patch fixes the powerpc [sic] and sparc64 build of the >>>>> default Mesa3D 7.4.4 after the 7.6.1 integration: >>>>> http://people.freebsd.org/~marius/mesa3d_7.6.1_unbreak.diff >>>>> Is it okay to commit? >>>> Looks good to me, this will save me some work now that I have both a >>>> powerpc and sparc64 boxes to play with. In looking at mesa git, I think >>>> I'll be making a few changes shortly... >>>> >>> So could someone please either approve or commit it (I have only >>> a src bit). >>> >> Looks to me like Robert already approved it. > > I think interpreting his comment as an "Approved by:" rather than > a "Reviewed by:" would be stretching it a bit too much. This was intended to be an approval, I'll follow on with some additional fixes, but let's get this committed first. Anyway... Approved by: rnoland@ robert. >> Having only a src commit bit shouldn't prevent your making a ports commit. >> I've seen ports committers make src commits. >> > > Sure, but you always need an explicit approval for committing to > a repository you don't have a bit for (at least so I've been told). > > Marius >