From owner-svn-src-head@FreeBSD.ORG Sun Apr 19 09:17:33 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 10C043FC; Sun, 19 Apr 2015 09:17:33 +0000 (UTC) Received: from mail-wi0-x22d.google.com (mail-wi0-x22d.google.com [IPv6:2a00:1450:400c:c05::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B0AFBECF; Sun, 19 Apr 2015 09:17:32 +0000 (UTC) Received: by widdi4 with SMTP id di4so66079123wid.0; Sun, 19 Apr 2015 02:17:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=UCQa0IgNjko/+A3rRvUw3sQgpQhiCfbSHqlyzrJoMSs=; b=nG/jfD/nd6DjWf2pRjKztWko2thFlEseTMN46jfVngpltLisylb0pEP137CXAEjD6Z MErq3/s9Gh2G3f9vkYMuuJLKMBBTR6cb7OgHCWRB8kG5hS/7WHPv0MqBNM6o+J1K604h E/SlWj4jz2zhl9FBiS2/AnQgHesOVRzOH7cMmcfKh43IwBWg84SFqMtbLOYlmeImgSB5 7BGwgcp6T93dCnxMZwnz9UIc+9QXawtJp4Z31j7/o2dS1GwIrX28VDQmLMepHiRoN+I+ EMFxlv6T1w6yDe4hmgqkifVVmAgF5WerYW9XC//KVC9TwBRfxlMSiVZLFlIsK2xld3/s hj3A== MIME-Version: 1.0 X-Received: by 10.194.236.33 with SMTP id ur1mr20701606wjc.77.1429435051175; Sun, 19 Apr 2015 02:17:31 -0700 (PDT) Sender: pluknet@gmail.com Received: by 10.27.80.202 with HTTP; Sun, 19 Apr 2015 02:17:31 -0700 (PDT) In-Reply-To: <201504190907.t3J97wiZ063971@svn.freebsd.org> References: <201504190907.t3J97wiZ063971@svn.freebsd.org> Date: Sun, 19 Apr 2015 12:17:31 +0300 X-Google-Sender-Auth: dthxEs8eZo9owv_rY852ySJ9Kzk Message-ID: Subject: Re: svn commit: r281734 - head/usr.sbin/inetd From: Sergey Kandaurov To: Eitan Adler Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Apr 2015 09:17:33 -0000 On 19 April 2015 at 12:07, Eitan Adler wrote: > Author: eadler > Date: Sun Apr 19 09:07:57 2015 > New Revision: 281734 > URL: https://svnweb.freebsd.org/changeset/base/281734 > > Log: > identd: remove redundant zeroing > se_rpc_lowvers was set to 0 twice, so remove one of them > I can not find any other variable which they may have been a typo of. > > Reported by: gcc5.1 > > Modified: > head/usr.sbin/inetd/inetd.c > > Modified: head/usr.sbin/inetd/inetd.c > ============================================================================== > --- head/usr.sbin/inetd/inetd.c Sun Apr 19 08:45:37 2015 (r281733) > +++ head/usr.sbin/inetd/inetd.c Sun Apr 19 09:07:57 2015 (r281734) > @@ -1752,8 +1752,7 @@ more: > memmove(sep->se_proto, sep->se_proto + 4, > strlen(sep->se_proto) + 1 - 4); > sep->se_rpc = 1; > - sep->se_rpc_prog = sep->se_rpc_lowvers = > - sep->se_rpc_lowvers = 0; > + sep->se_rpc_prog = sep->se_rpc_lowvers = 0; > memcpy(&sep->se_ctrladdr4, bind_sa4, > sizeof(sep->se_ctrladdr4)); > if ((versp = strrchr(sep->se_service, '/'))) { > se_rpc_highvers ? They both seem to be used prezeroed in a later sscanf(). -- wbr, pluknet