From owner-freebsd-python@freebsd.org Tue Mar 12 07:50:24 2019 Return-Path: Delivered-To: freebsd-python@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4E5C91517A42 for ; Tue, 12 Mar 2019 07:50:24 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id A6136818F6 for ; Tue, 12 Mar 2019 07:50:23 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id 600CD1517A40; Tue, 12 Mar 2019 07:50:23 +0000 (UTC) Delivered-To: python@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3D6CE1517A3E for ; Tue, 12 Mar 2019 07:50:23 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 18F12818EB; Tue, 12 Mar 2019 07:50:22 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pg1-x541.google.com with SMTP id h8so1188688pgp.6; Tue, 12 Mar 2019 00:50:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:reply-to:subject:to:references:from:cc:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=KfF/PRU3b+2aoeMs+ysQLt91blT6Moy/+glgnRGOqDU=; b=OOt7qhsO/9ExNkA/15paEqRWq4athCUfx7l+1ZuIimw2uG/Yx9Brwj4nVzeiFy7urB kLCyl6V54BFMMRv4XKc1dORr0yVo4EA1N5XFPx2lO43ML54Gw+2JhN1C+uuQFAXUHdoh hcOKqujIulvgYyQzExVmE4EqyhqPfqGgRpLWveRidYoiCUY/+0YXkopk+sM5DH0ce7fK TFGjoa4LiSdVd4WCFCOpXNJFu5BL7ltcppl58x8Dd3NPcWczVE7qDbl1RNNkbEU3nDxD SjKg99HabKKMQqCaGb9cx9bpJI2P2uieoATuih6LlKNGw6Uo7/WLjPb7BFjUdPX0/9AN sFDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:reply-to:subject:to:references:from:cc :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=KfF/PRU3b+2aoeMs+ysQLt91blT6Moy/+glgnRGOqDU=; b=IBzzb2xLUPpsSTLs2PXTubZH7d39g557pOn9FlUOFu7AqFvpVWP7xl/NOaIPpCa0GF QuMg00vY7T1yXi/OJcm4/8KtFxj0MIcmIcSFcy4sO8MBY1cVHvAohixBDrVFnOmwtrqF jk7CqE/Du8aptw1AHA8nnQmENSJtca2v7ldtSxtjLWKOgsxURuzS6jRPZSCJ+3qSmQDN mHAdXn0zVwluOUyCS/E/UEz4E/sA26Xlmw3KKxtioy8TvRlO08mQUghwXd1h9lGV+WY+ iXQx90dVsd9fJLkInUb/WV+Cij3nyWZ/0qLI9N/fzIYIOShLW4xmlRvR++wGZjE2XcK8 MYLg== X-Gm-Message-State: APjAAAUuiXTOKgFPPj7DwG1BTTK+l7Pa3ICku+966gZryK8QApBCBVVT qVckUdcNqbQUgLfsHd2jrjtuiqLV X-Google-Smtp-Source: APXvYqwbbmu38XxJL4F+6Cl27uUVcN8QxF87VfDUvwEHjVQ6VAbwtsBNV4ZIQZ74q3cfzEpuGkLbTw== X-Received: by 2002:a17:902:a5c6:: with SMTP id t6mr9080328plq.221.1552377020224; Tue, 12 Mar 2019 00:50:20 -0700 (PDT) Received: from ?IPv6:2403:5800:7100:5d01:e1de:3451:ae4b:9c1a? (2403-5800-7100-5d01-e1de-3451-ae4b-9c1a.ip6.aussiebb.net. [2403:5800:7100:5d01:e1de:3451:ae4b:9c1a]) by smtp.gmail.com with ESMTPSA id y8sm14052329pge.35.2019.03.12.00.50.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Mar 2019 00:50:19 -0700 (PDT) Sender: Kubilay Kocak Reply-To: koobs@FreeBSD.org Subject: Re: right procedure committing changes to core ports? To: Koichiro Iwao References: <20190312013900.mt5s43wy7zjzoxga@icepick.vmeta.jp> From: Kubilay Kocak Cc: ports-committers@FreeBSD.org, python Message-ID: <0502b927-6c97-275b-64a6-91c9e6144dab@FreeBSD.org> Date: Tue, 12 Mar 2019 07:50:16 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:66.0) Gecko/20100101 Thunderbird/66.0 MIME-Version: 1.0 In-Reply-To: <20190312013900.mt5s43wy7zjzoxga@icepick.vmeta.jp> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 18F12818EB X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=OOt7qhsO; spf=pass (mx1.freebsd.org: domain of koobsfreebsd@gmail.com designates 2607:f8b0:4864:20::541 as permitted sender) smtp.mailfrom=koobsfreebsd@gmail.com X-Spamd-Result: default: False [-1.53 / 15.00]; HAS_REPLYTO(0.00)[koobs@FreeBSD.org]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; DKIM_TRACE(0.00)[gmail.com:+]; FORGED_SENDER(0.30)[koobs@FreeBSD.org,koobsfreebsd@gmail.com]; MIME_TRACE(0.00)[0:+]; SUBJECT_ENDS_QUESTION(1.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; FROM_NEQ_ENVFROM(0.00)[koobs@FreeBSD.org,koobsfreebsd@gmail.com]; MID_RHS_MATCH_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.94)[-0.936,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; TAGGED_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-0.99)[-0.991,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; NEURAL_SPAM_SHORT(0.06)[0.057,0]; RCVD_TLS_LAST(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[1.4.5.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(-0.45)[ip: (2.65), ipnet: 2607:f8b0::/32(-2.74), asn: 15169(-2.08), country: US(-0.07)] X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Mar 2019 07:50:24 -0000 On 12/03/2019 1:39 am, Koichiro Iwao wrote: > Hi, > > I'm willing to commit this. It fixes lang/python27 to build with > libressl{,-devel} but it seems few people interested in that. > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234568 > > I'd appreciate if someone tell me the right procedure committing changes > to core ports such as lang/python*, lang/perl*. I mean core ports are > important ports that affect almost all ports users. > > Do I have to get someone's approval to commit it? > Hi Koichiro, There's a few distinct issues in this: 1) Approval for python@ ports, in general: Yes they require python@ approval as we're on the hook for QA/regressions/maintainership. For non-core ports (other than lang/python*, setuptools and a few other important ports) commit by maintainer timeout *with complete QA* is of course fine. Unfortunately there's no way to codify a 'core/non-core' or other useful policy/maintainership distinctions by way of a MAINTAINER_POLICY or similar, so the difference between 'this port is super important and requires extra eyes/review' and 'we're just a fallback/defacto maintainer' is not apparent or obvious. I expect this is a similar issue in other major porting teams (gnome, kde, ruby, et al) too. 2) The python build system is *notoriously* sensitive to changes, particularly with apparently simple CFLAGS, *FLAGS, environment changes. This is *especially* the case with *ssl library support, which a comment of yours in a separate but related issue testifies to: "The patch fixes build with libressl, libressl-devel, openssl111 but breaks openssl." [1] 3) Python build/upstream code fixes, especially for library support really need to 'go upstream' by default. It may be the case that this has already been solved up stream. I have seen libressl issues reported upstream, but I have not followed their status or resolution. There's no indication in the issue so far of that kind of analysis. It's much easier/faster to review and approve a commit by someone not on the python team if there's been a upstream bug report and commit merged to address the issue. We've worked very hard to reduce our diffs to upstream and, we still have a way to go. 4) This specific issue (building with libressl): the report and patch is for 2.7, but there's no information provided for whether or not 3.x requires the same treatment, or if there are similar (exactly the same?, slightly different?) issues in those branches, and across libressl versions. Given we have multiple branches of Python to support at any one time, its especially important to address issues as consistently and completely across all of those versions, where relevant, as possible, with complete and extensive QA. Committing changes is easy, understanding, analysing, ensuring a complete and correct change proposal is the difficult part. Happy to discuss this with you further on IRC, #freebsd-python @ freenode ./koobs [1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229223#c9