From owner-freebsd-hackers Thu Feb 12 13:11:43 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id NAA02499 for hackers-outgoing; Thu, 12 Feb 1998 13:11:43 -0800 (PST) (envelope-from owner-freebsd-hackers@FreeBSD.ORG) Received: from frmug.org (frmug-gw.frmug.org [193.56.58.252]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id NAA02464 for ; Thu, 12 Feb 1998 13:11:12 -0800 (PST) (envelope-from charnier@xp11.frmug.org) Received: (from uucp@localhost) by frmug.org (8.8.8/frmug-2.2/nospam) with UUCP id WAA12218; Thu, 12 Feb 1998 22:10:00 +0100 (CET) (envelope-from charnier@xp11.frmug.org) Received: from localhost (localhost [127.0.0.1]) by xp11.frmug.org (8.8.8/8.8.8/xp11-uucp-1.1) with ESMTP id UAA01693; Thu, 12 Feb 1998 20:30:27 +0100 (CET) (envelope-from charnier@xp11.frmug.org) Message-Id: <199802121930.UAA01693@xp11.frmug.org> To: cjs@netbsd.org cc: hackers@FreeBSD.ORG, support@bsdi.com Subject: Re: tail -F patches Date: Thu, 12 Feb 1998 20:30:27 +0100 From: "Philippe Charnier" Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Hello, In the patch you posted: + if ((fp = fopen(fname, "r")) == NULL) + err(1, "can't reopen %s: %s", + fname, strerror(errno)); Err(3) already displays the output of `strerror(errno)', so the following will suffice: err(1, "can't reopen %s", fname); - err(1, "-f option only appropriate for a single file"); + err(1, "-f and -F options only appropriate for a single file"); No need to use err(3) here because errno is nothing but garbage. Use errx(3) instead. Have a nice day. ------ ------ Philippe Charnier charnier@{lirmm.fr,xp11.frmug.org,FreeBSD.org} ``a PC not running FreeBSD is like a venusian with no tentacles'' ------------------------------------------------------------------------ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe hackers" in the body of the message