From owner-cvs-all@FreeBSD.ORG Tue Sep 25 17:12:10 2007 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6391616A417; Tue, 25 Sep 2007 17:12:10 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from relay02.kiev.sovam.com (relay02.kiev.sovam.com [62.64.120.197]) by mx1.freebsd.org (Postfix) with ESMTP id E1F0013C45B; Tue, 25 Sep 2007 17:12:09 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from [212.82.216.226] (helo=deviant.kiev.zoral.com.ua) by relay02.kiev.sovam.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.67) (envelope-from ) id 1IaDxA-000KDW-AR; Tue, 25 Sep 2007 20:12:09 +0300 Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.1/8.14.1) with ESMTP id l8PHC4Q6026717; Tue, 25 Sep 2007 20:12:04 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.1/8.14.1/Submit) id l8PHC4sg026716; Tue, 25 Sep 2007 20:12:04 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 25 Sep 2007 20:12:04 +0300 From: Kostik Belousov To: Alan Cox Message-ID: <20070925171204.GJ87366@deviant.kiev.zoral.com.ua> References: <200709250625.l8P6P7w7082233@repoman.freebsd.org> <20070925110147.GC60963@rink.nu> <46F93B16.50102@cs.rice.edu> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wA9WyeW1yVBM2Q32" Content-Disposition: inline In-Reply-To: <46F93B16.50102@cs.rice.edu> User-Agent: Mutt/1.4.2.3i X-Scanner-Signature: 3b10ce253585130f5293a5b36593fd37 X-DrWeb-checked: yes X-SpamTest-Envelope-From: kostikbel@gmail.com X-SpamTest-Group-ID: 00000000 X-SpamTest-Info: Profiles 1517 [September 25 2007] X-SpamTest-Info: helo_type=3 X-SpamTest-Info: {received from trusted relay: not dialup} X-SpamTest-Method: none X-SpamTest-Method: Local Lists X-SpamTest-Rate: 0 X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0255], KAS30/Release Cc: Alan Cox , cvs-src@freebsd.org, Rink Springer , src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/amd64/include vmparam.h src/sys/arm/include vmparam.h src/sys/i386/include vmparam.h src/sys/ia64/include vmparam.h src/sys/kern kern_exec.c vfs_bio.c src/sys/powerpc/include vmparam.h src/sys/sparc64/include ... X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Sep 2007 17:12:10 -0000 --wA9WyeW1yVBM2Q32 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 25, 2007 at 11:45:10AM -0500, Alan Cox wrote: > Rink Springer wrote: > >Hi Alan, > > > >On Tue, Sep 25, 2007 at 06:25:07AM +0000, Alan Cox wrote: > > =20 > >> Change the management of cached pages (PQ_CACHE) in two fundamental > >> ways: > >> =20 > > > >With this change, KDE no longer starts up; the process 'kbuildsycoca' > >seems to wait forever in status 'madvpo'. Reverting this changeset fixes > >the problem. > > > > =20 >=20 > This is a problem with madvise(WILLNEED). I believe that the attached=20 > patch will fix it. >=20 > Thanks, > Alan >=20 >=20 >=20 > Index: vm/vm_object.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /home/ncvs/src/sys/vm/vm_object.c,v > retrieving revision 1.383 > diff -p -u -r1.383 vm_object.c > --- vm/vm_object.c 25 Sep 2007 06:25:06 -0000 1.383 > +++ vm/vm_object.c 25 Sep 2007 16:17:40 -0000 > @@ -1105,7 +1105,8 @@ shadowlookup: > /* > * If the page is cached, reactivate it. > */ > - m =3D vm_page_alloc(tobject, tpindex, VM_ALLOC_IFCACHED); > + m =3D vm_page_alloc(tobject, tpindex, VM_ALLOC_IFCACHED | > + VM_ALLOC_NOBUSY); > } > if (m =3D=3D NULL) { > /* Yes, this indeed fixes the problem. Several minutes ago I suggested the same change to rdivacky@, and he reported that the problem is gone. --wA9WyeW1yVBM2Q32 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFG+UFkC3+MBN1Mb4gRAtfIAKCrq7KDkSWp4X4XTK5ukM61V8XUhgCglu5h BaF1Wk3DLEFp2eqSsFM4Mps= =5eLU -----END PGP SIGNATURE----- --wA9WyeW1yVBM2Q32--