Date: Mon, 7 Jun 2004 17:50:43 -0400 (EDT) From: Robert Watson <rwatson@freebsd.org> To: Stefan Ehmann <shoesoft@gmx.net>, Arjan van Leeuwen <avleeuwen@piwebs.com> Cc: freebsd-current@freebsd.org Subject: Re: file descripter leak in current with Qmail? Message-ID: <Pine.NEB.3.96L.1040607174923.88690M-100000@fledge.watson.org> In-Reply-To: <1086642350.827.1.camel@taxman>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 7 Jun 2004, Stefan Ehmann wrote: > On Mon, 2004-06-07 at 22:38, Robert Watson wrote: > > On Mon, 7 Jun 2004, Arjan van Leeuwen wrote: > > > I get a panic (address not allocated) when using the patch. I can't > > > write down any useful details about it right now, because although the > > > server has only 3 users, they're very disconcerned when I disrupt their > > > internet traffic :). > > > > Doh. Sorry about that. Revised patch attached. I'm able to test the > > leak with the attached C file, and on my test box (now that it doesn't > > panic), the leak appears fixed for non-blocking accepts. > > Thanks, that fixed it here too. Ok, I've gone ahead and merged the fix. Thanks for the bug report, and thanks to Brian for the pointer at the accept() change. The reason I became involved in the thread in the first place was that I was worried it might be something like this, and indeed, it was. Let me know if you have any further problems of this sort. There will probably be some more nits like this as more locking is merged -- hence merging it in small functional changes in as much as is possible, allowing each change to shake out some before the next batch. Thanks! Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Senior Research Scientist, McAfee Research
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.NEB.3.96L.1040607174923.88690M-100000>