From owner-freebsd-hackers@FreeBSD.ORG  Tue Nov 30 11:33:55 2010
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A34A4106566B
	for <freebsd-hackers@freebsd.org>; Tue, 30 Nov 2010 11:33:55 +0000 (UTC)
	(envelope-from des@des.no)
Received: from smtp.des.no (smtp.des.no [194.63.250.102])
	by mx1.freebsd.org (Postfix) with ESMTP id 62BDA8FC08
	for <freebsd-hackers@freebsd.org>; Tue, 30 Nov 2010 11:33:55 +0000 (UTC)
Received: from ds4.des.no (des.no [84.49.246.2])
	by smtp.des.no (Postfix) with ESMTP id 5BDB71FFC38;
	Tue, 30 Nov 2010 11:33:54 +0000 (UTC)
Received: by ds4.des.no (Postfix, from userid 1001)
	id 305E5845DB; Tue, 30 Nov 2010 12:33:54 +0100 (CET)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: Bakul Shah <bakul@bitblocks.com>
References: <86r5e3zye4.fsf@pluton.xbsd.name> <4CF40F8F.30303@feral.com>
	<20101129221648.159C45B18@mail.bitblocks.com>
Date: Tue, 30 Nov 2010 12:33:54 +0100
In-Reply-To: <20101129221648.159C45B18@mail.bitblocks.com> (Bakul Shah's
	message of "Mon, 29 Nov 2010 14:16:47 -0800")
Message-ID: <86zksrm4f1.fsf@ds4.des.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: freebsd-hackers@freebsd.org, Matthew Jacob <mj@feral.com>
Subject: Re: find(1): Is this a bug or not?
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Nov 2010 11:33:55 -0000

Bakul Shah <bakul@bitblocks.com> writes:
> Index: function.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- function.c  (revision 212707)
> +++ function.c  (working copy)
> @@ -560,7 +560,7 @@
> 		empty =3D 1;
> 		dir =3D opendir(entry->fts_accpath);
> 		if (dir =3D=3D NULL)
> -			err(1, "%s", entry->fts_accpath);
> +			return 0;
> 		for (dp =3D readdir(dir); dp; dp =3D readdir(dir))
> 		        if (dp->d_name[0] !=3D '.' ||
> 			    (dp->d_name[1] !=3D '\0' &&

You should replace the err() call with a warn() call instead of removing
it outright.

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no