From nobody Wed Dec 3 14:30:35 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dM0Rf1GhYz6JTc8; Wed, 03 Dec 2025 14:30:38 +0000 (UTC) (envelope-from markj@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dM0Rd5cSNz3JTw; Wed, 03 Dec 2025 14:30:37 +0000 (UTC) (envelope-from markj@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1764772237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/EV/rpeymvxyJP7o65rTesvNLxwFHoq+FRjeocIeHWA=; b=JxJ3hhQngDs3UzI5TgVJ7fw3XLclb8lI9tf7UIQgtbPaTlkCbNVqBtSsja9LaScdty177G KJCuNNwMKOTw39Xp9GjP+Uv18E+PFwEtsZdNnsFpZCbJYYGKa0s+Y9zgMjw5ZwUe1YORf8 esqeM+N0uwBTKnW5/MIqFRrknDRwdEpBuExp5jEMrJnVtwWMgAJ3xACmieizhGzObSY/TS I55VeOR51yTol9n7YmP26/i8J7jUmtfh/2iiPJsvjd6JtVOTXGkgrePxnlVRZFQ8g6HU01 TRePkkdPRB4MXNDz+O0qROLlc/VqD8SS2JQ8EtZoVoX0VSYMVGBaP0ELQ5SNtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1764772237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/EV/rpeymvxyJP7o65rTesvNLxwFHoq+FRjeocIeHWA=; b=inJNHqqqon6YpzRK1gYWraCAVlDVENPla+aaA1D3pg2apmK2pxqWjpTF3z3GuT3p9+HAmu aXB03kyXsByMOa70R/xTcvZMgvWS1wrjEovSyOB24ovAHYU96Ofu1g2CSC+hmldKX6uTOZ 7JxGBsVn/+DQgr39CuDUG9xtbWVAdcWAFsvDZsbl7I+kWFkIEKBnXpaWtpzFMDjmfa7bBO yfLuSMGfn+2w8Q+MrpYHUckckmAV84FSHSAjNZAkgp91d604rm+6iYVsTo0DLJxl4rd4CI 6sOUbBwOSxq9YiWrbhxIJNENTGH8aDNxzA/PwJ8x9X/uRdA1CF6oKOPICZgVMA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1764772237; a=rsa-sha256; cv=none; b=OJGvgFiGSJyNaRGGQrTQ4TuiRYoFJwYgPKoPgHUO2oSWCNNqkiQesrJW5R10EnV0F2tshC R/gSpFUB4CF/hPQhAh/pw7fEplm+/IxKDjK3WDKyXartpq3tG46Ej8erbs5LTKo+gBfp9U 1kvaEiVT7mlB48RLBjrdax4SxlPPhkbva4pI/bsfbiu7D+c+Ht+Hh0JBu5MpghNz4ucrQi OML8gQL1zfv3ZYmA3BZJ5YXOrpb1rrCKfyWZkGyn286EvwiKgXK37N+1CixUzzgGSSTHur 6LiWCgP9lxX1RA0+Xkv5YrACMeMndU1GXRyxJBXvb8wV/PYS40oIU+iTCyUakA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from nuc (192-0-220-237.cpe.teksavvy.com [192.0.220.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: markj) by smtp.freebsd.org (Postfix) with ESMTPSA id 4dM0Rd38bzzBct; Wed, 03 Dec 2025 14:30:37 +0000 (UTC) (envelope-from markj@freebsd.org) Date: Wed, 3 Dec 2025 09:30:35 -0500 From: Mark Johnston To: Sumit Saxena Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 35dd53a9e132 - main - librdmacm/libibverbs: Statically bound libbnxtre.so.1 to rping Message-ID: References: <69302037.3d155.40084cd7@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <69302037.3d155.40084cd7@gitrepo.freebsd.org> On Wed, Dec 03, 2025 at 11:34:15AM +0000, Sumit Saxena wrote: > The branch main has been updated by ssaxena: > > URL: https://cgit.FreeBSD.org/src/commit/?id=35dd53a9e13265f7a479649776453efc5b737a0f > > commit 35dd53a9e13265f7a479649776453efc5b737a0f > Author: Sumit Saxena > AuthorDate: 2025-12-03 11:28:33 +0000 > Commit: Sumit Saxena > CommitDate: 2025-12-03 11:33:40 +0000 > > librdmacm/libibverbs: Statically bound libbnxtre.so.1 to rping > > By default ibv_devices and rping are not statically bound to > libbnxtre.so.1. i.e. 'ldd /usr/bin/rping' command doesn't list > 'libbnxtre.so.1' entry. So, statically bound the libbnxtre.so.1 > library to rping & ibv_devices utils. > > MFC-After: 3 days > Reviewed-by: sumit.saxena@broadcom.com > Differential-Revision: https://reviews.freebsd.org/D49604 > --- > share/mk/src.libnames.mk | 7 +++++-- > usr.bin/ofed/libibverbs/Makefile.inc | 2 +- > usr.bin/ofed/librdmacm/Makefile.inc | 2 +- > 3 files changed, 7 insertions(+), 4 deletions(-) > > diff --git a/share/mk/src.libnames.mk b/share/mk/src.libnames.mk > index e108cc15fb55..125fe2242bd5 100644 > --- a/share/mk/src.libnames.mk > +++ b/share/mk/src.libnames.mk > @@ -285,6 +285,7 @@ _LIBRARIES+= \ > irdma \ > mlx4 \ > mlx5 \ > + bnxtre \ > rdmacm \ > osmcomp \ > opensm \ > @@ -360,7 +361,7 @@ _DP_cap_sysctl= nv > _DP_cap_syslog= nv > _DP_crypt= md > .if ${MK_OFED} != "no" > -_DP_pcap= ibverbs mlx5 > +_DP_pcap= ibverbs mlx5 bnxtre It's not clear from the commit message whether this part of the change was intentional. In any case, it breaks the build. Here is a patch which fixes it: https://reviews.freebsd.org/D54048 > .endif > _DP_pjdlog= util > _DP_usb= pthread > @@ -511,11 +512,12 @@ _DP_cxgb4= ibverbs pthread > _DP_ibcm= ibverbs > _DP_ibmad= ibumad > _DP_ibnetdisc= osmcomp ibmad ibumad > -_DP_ibumad= > +_DP_ibumad= > _DP_ibverbs= > _DP_irdma= ibverbs pthread > _DP_mlx4= ibverbs pthread > _DP_mlx5= ibverbs pthread > +_DP_bnxtre= ibverbs pthread > _DP_rdmacm= ibverbs > _DP_osmcomp= pthread > _DP_opensm= pthread > @@ -810,6 +812,7 @@ LIBIBVERBSDIR= ${_LIB_OBJTOP}/lib/ofed/libibverbs > LIBIRDMADIR= ${_LIB_OBJTOP}/lib/ofed/libirdma > LIBMLX4DIR= ${_LIB_OBJTOP}/lib/ofed/libmlx4 > LIBMLX5DIR= ${_LIB_OBJTOP}/lib/ofed/libmlx5 > +LIBBNXTREDIR= ${_LIB_OBJTOP}/lib/ofed/libbnxtre > LIBRDMACMDIR= ${_LIB_OBJTOP}/lib/ofed/librdmacm > LIBOSMCOMPDIR= ${_LIB_OBJTOP}/lib/ofed/complib > LIBOPENSMDIR= ${_LIB_OBJTOP}/lib/ofed/libopensm > diff --git a/usr.bin/ofed/libibverbs/Makefile.inc b/usr.bin/ofed/libibverbs/Makefile.inc > index 616c9bd54707..f8301c3d1073 100644 > --- a/usr.bin/ofed/libibverbs/Makefile.inc > +++ b/usr.bin/ofed/libibverbs/Makefile.inc > @@ -3,6 +3,6 @@ _spath=${SRCTOP}/contrib/ofed/libibverbs > > BINDIR?= /usr/bin > CFLAGS+= -I${_spath} > -LIBADD+= ibverbs mlx4 mlx5 cxgb4 irdma pthread > +LIBADD+= ibverbs mlx4 mlx5 bnxtre cxgb4 irdma pthread > > WARNS?= 2 > diff --git a/usr.bin/ofed/librdmacm/Makefile.inc b/usr.bin/ofed/librdmacm/Makefile.inc > index 74f32fe08b42..66fcf2ac267b 100644 > --- a/usr.bin/ofed/librdmacm/Makefile.inc > +++ b/usr.bin/ofed/librdmacm/Makefile.inc > @@ -3,6 +3,6 @@ _spath=${SRCTOP}/contrib/ofed/librdmacm > > BINDIR?= /usr/bin > CFLAGS+= -I${SRCTOP}/contrib/ofed > -LIBADD+= ibverbs rdmacm irdma mlx4 mlx5 cxgb4 pthread > +LIBADD+= ibverbs rdmacm irdma mlx4 mlx5 bnxtre cxgb4 pthread > > WARNS?= 0 >