From owner-svn-src-all@freebsd.org Tue Apr 9 16:18:13 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E7A451563833 for ; Tue, 9 Apr 2019 16:18:12 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1.eu.mailhop.org (outbound1.eu.mailhop.org [52.28.251.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5B84A6C998 for ; Tue, 9 Apr 2019 16:18:12 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1554826683; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=KXT3z+wIyxgCVZR+XPcXg4uWBEMnoeLSHdrGNfyNIRYQyup7e7n6YPZrI2pTn5KxFPWP311CKhvhc gZA+b6MOef1XN46F4ZyEcylKN/tW1PeL6+i4B5drZVfxOWYiK6KAYy/NLc6kub5FYS1z0QsFlyg61w FsA8ifa7M+Ubs352tALtCcfEqhTVNOI6GesVufsvNIm58FIhGDWx2oQkHcvZ+icHjRomGAWYrlHW2c X/u7Y5v3fnfeW/EfYCwwMJewNsgStPxSq5nVegjy5MDbhB2uTJ1gAIAgflHvUQj8wba1VulU+tw3+E 8LtpF+LvjS0/fOu6j43yKoMEkme9OiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:dkim-signature:from; bh=WzuN1Wvec35b2nuIbtCHqGdP5K2KjeoRb+NXPR3L4NA=; b=Z1wu4n0KFnA+qRIHTXU2X1R9MjusWe32BMO/jV68L6RKKfkTsdXlBOl6N2+A2LGzeCDIA0jyO6uZ5 I8jl8m+YictPzpaQfWkUqPFpDg45x/SNkuzdKg4V73HfppIvSfDjIlBFJsJ2770ocee7aCwuU/CKUD Ud2/r3v+QaEQMdbS9aYhfKhalXprwEiojEXPDIUADugKJaQep7jS3weB0mm2WUbgJInGkZfX+sC4Fw h5SM+2lpxZOJ4TUDXifoz8ZrS1PSXMZ6PtXlZgxheRF3nkMyfBJ7rTkxpYZ7orO8k0Nu2n5T8Lkb1Y 6pzKjY/qKvvGPKc/l3Cw39mvKXQaa6w== ARC-Authentication-Results: i=1; outbound3.eu.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:from; bh=WzuN1Wvec35b2nuIbtCHqGdP5K2KjeoRb+NXPR3L4NA=; b=ovRsmhwV5IZTHP9LJ21ihx64Pj4KpanmkcEztUKgt7VvCCX8G2/5rVTW6KjzJY44/RQmLDtoR/Foi X80Gj9DqYO/WSDQVG73tLEa0CRyF+JtMgQEuOnz4VWNZbJo11IFjJqmgFQW1GjXAWXIJ21+aAm49wC IZexIFV9RWJLXKbZzpOEgR9S5xPYXw1wkp6Da1uSsPDpJVpG43jZ2qXuu9GtckD1R7r5MrY4cGxMgC Fn0ekcqM0lNHVjSA2Ld9Vbz1B9Cc7nEE7ESBroH+7jXCYuDxFxoUFt3jfqceHM6pS5eQFewc8Ecky0 vZWGb3GyJDlZ0AK3gSa6F/MM5EqS23A== X-MHO-RoutePath: aGlwcGll X-MHO-User: 0a87784c-5ae3-11e9-908b-352056dbf2de X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound3.eu.mailhop.org (Halon) with ESMTPSA id 0a87784c-5ae3-11e9-908b-352056dbf2de; Tue, 09 Apr 2019 16:18:00 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id x39GHw56017970; Tue, 9 Apr 2019 10:17:58 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: Subject: Re: svn commit: r346052 - head/sys/dev/usb/net From: Ian Lepore To: John Baldwin , Ganbold Tsagaankhuu , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Tue, 09 Apr 2019 10:17:58 -0600 In-Reply-To: References: <201904091354.x39Ds9e6070857@repo.freebsd.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 5B84A6C998 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.98)[-0.980,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Apr 2019 16:18:13 -0000 On Tue, 2019-04-09 at 09:11 -0700, John Baldwin wrote: > On 4/9/19 6:54 AM, Ganbold Tsagaankhuu wrote: > > Author: ganbold > > Date: Tue Apr 9 13:54:08 2019 > > New Revision: 346052 > > URL: https://svnweb.freebsd.org/changeset/base/346052 > > > > Log: > > In some cases like NanoPI R1, its second USB ethernet > > RTL8152 (chip version URE_CHIP_VER_4C10) doesn't > > have hardwired MAC address, in other words, it is all zeros. > > This commit fixes it by setting random MAC address > > when MAC address is all zeros. > > > > Reviewed by: kevlo > > Differential Revision: https://reviews.freebsd.org/D19856 > > It would be best to not use a purely random mac address and to use > the > function kevans@ added recently. That function generates a MAC > address > from the FreeBSD OUI using a cryptographic hash so you get a > stable address across boots on a given host. > How could that possibly work? If it's not random, you can't have two such devices on the same network. If it is random, it's not stable from one boot to the next. -- Ian