From owner-p4-projects@FreeBSD.ORG  Thu Jan 29 16:24:36 2009
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id B24D81065677; Thu, 29 Jan 2009 16:24:35 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6CCD11065675
	for <perforce@freebsd.org>; Thu, 29 Jan 2009 16:24:35 +0000 (UTC)
	(envelope-from nwhitehorn@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 5ABBB8FC19
	for <perforce@freebsd.org>; Thu, 29 Jan 2009 16:24:35 +0000 (UTC)
	(envelope-from nwhitehorn@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n0TGOZ9j092549
	for <perforce@freebsd.org>; Thu, 29 Jan 2009 16:24:35 GMT
	(envelope-from nwhitehorn@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n0TGOZDd092547
	for perforce@freebsd.org; Thu, 29 Jan 2009 16:24:35 GMT
	(envelope-from nwhitehorn@freebsd.org)
Date: Thu, 29 Jan 2009 16:24:35 GMT
Message-Id: <200901291624.n0TGOZDd092547@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	nwhitehorn@freebsd.org using -f
From: Nathan Whitehorn <nwhitehorn@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 156869 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Jan 2009 16:24:38 -0000

http://perforce.freebsd.org/chv.cgi?CH=156869

Change 156869 by nwhitehorn@nwhitehorn_trantor on 2009/01/29 16:23:36

	Change the synchronization strategy for tlbie calls to correctly
	use ptesync and to avoid unnecessary sync operations at the end.

Affected files ...

.. //depot/projects/ppc-g5/sys/powerpc/aim/mmu_oea64.c#13 edit

Differences ...

==== //depot/projects/ppc-g5/sys/powerpc/aim/mmu_oea64.c#13 (text+ko) ====

@@ -191,8 +191,6 @@
 	uint64_t vpn;
 	register_t vpn_hi, vpn_lo;
 
-	SYNC();
-
 #if 1
 	/*
 	 * CPU documentation says that tlbie takes the VPN, not the
@@ -214,19 +212,17 @@
 	    clrldi %1,%0,49; \
 	    insrdi %1,1,1,0; \
 	    mtmsrd %1; \
-	    isync; \
+	    ptesync; \
 	    \
 	    sld %1,%2,%4; \
 	    or %1,%1,%3; \
 	    tlbie %1; \
 	    \
 	    mtmsrd %0; \
-	    isync;" 
+	    eieio; \
+	    tlbsync; \
+	    ptesync;" 
 	: "=r"(msr), "=r"(scratch) : "r"(vpn_hi), "r"(vpn_lo), "r"(32));
-
-	EIEIO();
-	TLBSYNC();
-	SYNC();
 }
 
 #define DISABLE_TRANS(msr)	msr = mfmsr(); mtmsr(msr & ~PSL_DR); isync()