From owner-p4-projects@FreeBSD.ORG  Mon May  5 08:50:24 2003
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 2EE2F37B401; Mon,  5 May 2003 08:50:24 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A6B4E37B404
	for <perforce@freebsd.org>; Mon,  5 May 2003 08:50:23 -0700 (PDT)
Received: from mail.speakeasy.net (mail15.speakeasy.net [216.254.0.215])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 973AA43FCB
	for <perforce@freebsd.org>; Mon,  5 May 2003 08:50:22 -0700 (PDT)
	(envelope-from jhb@FreeBSD.org)
Received: (qmail 20598 invoked from network); 5 May 2003 15:50:25 -0000
Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63])
	(envelope-sender <jhb@FreeBSD.org>)encrypted SMTP
	for <imp@bsdimp.com>; 5 May 2003 15:50:25 -0000
Received: from laptop.baldwin.cx ([216.133.140.1])
	by server.baldwin.cx (8.12.8/8.12.8) with ESMTP id h45FoHdt014584;
	Mon, 5 May 2003 11:50:19 -0400 (EDT)
	(envelope-from jhb@FreeBSD.org)
Message-ID: <XFMail.20030505115019.jhb@FreeBSD.org>
X-Mailer: XFMail 1.5.4 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <20030503233424.A8651@FreeBSD.org>
Date: Mon, 05 May 2003 11:50:19 -0400 (EDT)
From: John Baldwin <jhb@FreeBSD.org>
To: Juli Mallett <jmallett@FreeBSD.org>
cc: perforce@freebsd.org
cc: "M. Warner Losh" <imp@bsdimp.com>
Subject: Re: PERFORCE change 30435 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 05 May 2003 15:50:25 -0000


On 04-May-2003 Juli Mallett wrote:
> * "M. Warner Losh" <imp@bsdimp.com> [ Date: 2003-05-03 ]
>       [ w.r.t. Re: PERFORCE change 30435 for review ]
>> In message: <200305030240.h432elND072264@repoman.freebsd.org>
>>             Juli Mallett <jmallett@freebsd.org> writes:
>> : http://perforce.freebsd.org/chv.cgi?CH=30435
>> : 
>> : Change 30435 by jmallett@jmallett_dalek on 2003/05/02 19:40:13
>> : 
>> :    Erk, remove redundant call to cp0_status_read.
>> : 
>> : Affected files ...
>> : 
>> : .. //depot/projects/mips/sys/mips/include/cpufunc.h#8 edit
>> : 
>> : Differences ...
>> : 
>> : ==== //depot/projects/mips/sys/mips/include/cpufunc.h#8 (text+ko) ====
>> : 
>> : @@ -38,7 +38,6 @@
>> :  {
>> :    register_t s;
>> :  
>> : -  s = mips_cp0_status_read();
>> :    mips_cp0_status_write((s = mips_cp0_status_read()) & ~MIPS_SR_IE);
>> :    return (s);
>> :  }
>> 
>> Sure this is really redundant and not there for some weird mips box's
>> pipeline delay requirements?
> 
> I just forgot to dd the line after I decided to nest it.

I personally find the unnested version easier to read.

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/