From owner-cvs-all@FreeBSD.ORG Mon Dec 8 09:04:12 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3B47416A4CE; Mon, 8 Dec 2003 09:04:12 -0800 (PST) Received: from ns1.xcllnt.net (209-128-86-226.BAYAREA.NET [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 52C2843F93; Mon, 8 Dec 2003 09:04:10 -0800 (PST) (envelope-from marcel@xcllnt.net) Received: from dhcp01.pn.xcllnt.net (dhcp01.pn.xcllnt.net [192.168.4.201]) by ns1.xcllnt.net (8.12.10/8.12.10) with ESMTP id hB8H49OE013794; Mon, 8 Dec 2003 09:04:10 -0800 (PST) (envelope-from marcel@piii.pn.xcllnt.net) Received: from dhcp01.pn.xcllnt.net (localhost [127.0.0.1]) hB8H49ow003733; Mon, 8 Dec 2003 09:04:09 -0800 (PST) (envelope-from marcel@dhcp01.pn.xcllnt.net) Received: (from marcel@localhost) by dhcp01.pn.xcllnt.net (8.12.10/8.12.10/Submit) id hB8H49NX003732; Mon, 8 Dec 2003 09:04:09 -0800 (PST) (envelope-from marcel) Date: Mon, 8 Dec 2003 09:04:09 -0800 From: Marcel Moolenaar To: Bruce Evans Message-ID: <20031208170409.GA3666@dhcp01.pn.xcllnt.net> References: <200312080757.hB87vvTA048651@repoman.freebsd.org> <20031208225505.H6229@gamplex.bde.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20031208225505.H6229@gamplex.bde.org> User-Agent: Mutt/1.5.5.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/vmstat vmstat.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Dec 2003 17:04:12 -0000 On Mon, Dec 08, 2003 at 11:13:53PM +1100, Bruce Evans wrote: > On Sun, 7 Dec 2003, Marcel Moolenaar wrote: > > > marcel 2003/12/07 23:57:57 PST > > > > FreeBSD src repository > > > > Modified files: > > usr.bin/vmstat vmstat.c > > Log: > > Unbreak vmstat -i on ia64: > > o nintr and inamlen must by of type size_t, not int, > > o Remove now unnecessary casts, > > o Handle the aflag differently, because the intr. names have a > > fixed width and almost always have trailing spaces. > > The fixed width and padding with spaces is a new kernel bug on i386's. > Was it broken before on ia64's? vmstat -i worked (and works again) on ia64. The interface remains broken. > I don't like the aflag handling and removed most of it. Interrupts > with nonzero counts should always be displayed (like they used to be), > and there is little need for different levels of allness. Genuine interrupt sources with zero counts should always be displayed, but since the interface is broken, we don't know if an entry is genuine or not. > This patch depends on other changes to print the rate more precisely. As long as we divide the count by the uptime, there's no way we can ever have any form of precision. This is ok for the one-shot output, but the repeated output should base the rate on the difference between the new and the old values, divided by the repeat interval. -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net