From owner-p4-projects Sun Dec 22 15:49:44 2002 Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 638EB37B406; Sun, 22 Dec 2002 15:49:42 -0800 (PST) Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EDBAC37B405 for ; Sun, 22 Dec 2002 15:49:41 -0800 (PST) Received: from kayak.xcllnt.net (209-128-86-226.BAYAREA.NET [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4669243EDC for ; Sun, 22 Dec 2002 15:49:41 -0800 (PST) (envelope-from marcel@xcllnt.net) Received: from athlon.pn.xcllnt.net (athlon.pn.xcllnt.net [192.168.4.3]) by kayak.xcllnt.net (8.12.6/8.12.6) with ESMTP id gBMNnYrT099097; Sun, 22 Dec 2002 15:49:34 -0800 (PST) (envelope-from marcel@kayak.pn.xcllnt.net) Received: from athlon.pn.xcllnt.net (localhost [127.0.0.1]) by athlon.pn.xcllnt.net (8.12.6/8.12.6) with ESMTP id gBMNnYdT001485; Sun, 22 Dec 2002 15:49:34 -0800 (PST) (envelope-from marcel@athlon.pn.xcllnt.net) Received: (from marcel@localhost) by athlon.pn.xcllnt.net (8.12.6/8.12.6/Submit) id gBMNnX1J001484; Sun, 22 Dec 2002 15:49:33 -0800 (PST) (envelope-from marcel) Date: Sun, 22 Dec 2002 15:49:33 -0800 From: Marcel Moolenaar To: "M. Warner Losh" Cc: perforce@freebsd.org Subject: Re: PERFORCE change 22626 for review Message-ID: <20021222234933.GB1414@athlon.pn.xcllnt.net> References: <200212221927.gBMJR0si013191@repoman.freebsd.org> <20021222.151026.100645554.imp@bsdimp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20021222.151026.100645554.imp@bsdimp.com> User-Agent: Mutt/1.5.1i Sender: owner-p4-projects@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, Dec 22, 2002 at 03:10:26PM -0700, M. Warner Losh wrote: > In message: <200212221927.gBMJR0si013191@repoman.freebsd.org> > Marcel Moolenaar writes: > : static int > : sio_pccard_detach(dev) > : device_t dev; > : { > : - return (siodetach(dev)); > : + /* XXX broken */ > : } > > This is clearly not acceptible. I completely fail to see why. I have to get a job done and as long as I don't commit it to CVS I don't see why I cannot break anything that's not immediately relevant to ia64 or to the job at hand. The primary reason for this kind of axing is that I cannot test it at all and it can only create bugs if I try to preserve it. It's much better to get rid of it and spend the extra effort when it's being restored. A second reason why I don't worry about it now is that it's not specific to pccard anymore. -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message