From owner-freebsd-ports-bugs@freebsd.org Mon Dec 16 22:31:02 2019 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 982501D04BA for ; Mon, 16 Dec 2019 22:31:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 47cGFf3dGsz4Plv for ; Mon, 16 Dec 2019 22:31:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 7A5831D04B9; Mon, 16 Dec 2019 22:31:02 +0000 (UTC) Delivered-To: ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7A18C1D04B8 for ; Mon, 16 Dec 2019 22:31:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47cGFf2h0cz4Pls for ; Mon, 16 Dec 2019 22:31:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 578C844BB for ; Mon, 16 Dec 2019 22:31:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id xBGMV2nH084153 for ; Mon, 16 Dec 2019 22:31:02 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id xBGMV2bo084152 for ports-bugs@FreeBSD.org; Mon, 16 Dec 2019 22:31:02 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 242673] net-mgmt/arpwatch: rc script breaks when arpwatch_interfaces contains a dot Date: Mon, 16 Dec 2019 22:31:02 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: dd@goboomtown.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: leres@freebsd.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter flagtypes.name Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Dec 2019 22:31:02 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D242673 Bug ID: 242673 Summary: net-mgmt/arpwatch: rc script breaks when arpwatch_interfaces contains a dot Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: leres@freebsd.org Reporter: dd@goboomtown.com Assignee: leres@freebsd.org Flags: maintainer-feedback?(leres@freebsd.org) Hi, I just installed the 3.0 update and found a bug. Here=E2=80=99s how we con= figure arpwatch on our firewalls: [dd@fw1 etc]$ grep arpwatch /etc/rc.conf arpwatch_enable=3D"YES" arpwatch_interfaces=3D"lagg0.6 lagg0.7 lagg0.10" Here=E2=80=99s what happened on start: [dd@fw1 dd]$ sudo service arpwatch start Starting arpwatch. Version 3.0 usage: arpwatch [-CdFNpqsvzZ] [-D arpdir] [-f datafile] [-i interface] [-P pidfile] [-w watcher@email] [-W watchee@email] [-n net[/width]] [-x net[/width]] [-r file] /usr/local/etc/rc.d/arpwatch: WARNING: failed to start arpwatch Starting arpwatch. Version 3.0 usage: arpwatch [-CdFNpqsvzZ] [-D arpdir] [-f datafile] [-i interface] [-P pidfile] [-w watcher@email] [-W watchee@email] [-n net[/width]] [-x net[/width]] [-r file] /usr/local/etc/rc.d/arpwatch: WARNING: failed to start arpwatch Starting arpwatch. Version 3.0 usage: arpwatch [-CdFNpqsvzZ] [-D arpdir] [-f datafile] [-i interface] [-P pidfile] [-w watcher@email] [-W watchee@email] [-n net[/width]] [-x net[/width]] [-r file] /usr/local/etc/rc.d/arpwatch: WARNING: failed to start arpwatch Turns out it was a simple bug in the `eval` of the rc.d/arpwatch script.=20 Here=E2=80=99s what fixed it for me: [dd@fw1 etc]$ diff -u rc.d/arpwatch.bad rc.d/arpwatch --- rc.d/arpwatch.bad 2019-12-16 02:02:32.000000000 -0800 +++ rc.d/arpwatch 2019-12-16 12:33:12.376475000 -0800 @@ -47,7 +47,8 @@ if [ $cmd =3D=3D start ]; then prep_datfile ${fn} fi - eval options=3D\$arpwatch_${interface}_options + options_interface=3D`echo ${interface} | tr '.' '_'` + eval options=3D\$arpwatch_${options_interface}_options command_args=3D"-i ${interface} -f ${fn} -P ${pidfile} ${options}" } My fix is probably a bit primitive, but should help someone make the perman= ent fix. Thanks, Daniel --=20 You are receiving this mail because: You are the assignee for the bug.=