From owner-svn-ports-head@FreeBSD.ORG  Fri Aug  1 06:26:23 2014
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 563531FC;
 Fri,  1 Aug 2014 06:26:23 +0000 (UTC)
Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 24CBC2C95;
 Fri,  1 Aug 2014 06:26:22 +0000 (UTC)
Received: from [192.168.0.21] (unknown [130.255.19.191])
 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
 (No client certificate requested)
 by shepard.synsport.net (Postfix) with ESMTP id 49972435C7;
 Fri,  1 Aug 2014 01:26:00 -0500 (CDT)
Message-ID: <53DB32E8.7020700@marino.st>
Date: Fri, 01 Aug 2014 08:25:44 +0200
From: John Marino <freebsd.contact@marino.st>
Reply-To: marino@freebsd.org
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:24.0) Gecko/20100101 Thunderbird/24.5.0
MIME-Version: 1.0
To: Alexey Dokuchaev <danfe@FreeBSD.org>, marino@freebsd.org
Subject: Re: svn commit: r363361 - in head/editors/fte: . files
References: <2D24420529C9ECAEABB9A791@atuin.in.mat.cc>
 <53D8A2BB.7090704@marino.st> <6270029E710D3C52B60B6224@atuin.in.mat.cc>
 <20140730081413.GA29876@FreeBSD.org> <20140730160843.GA2688@FreeBSD.org>
 <53D919BC.6010307@marino.st> <20140801051652.GA59625@FreeBSD.org>
 <CAALwa8=R2i9PA7R8VXHStZCDGy_ZFaYcBtRmY-_ZFq9k=toJ+w@mail.gmail.com>
 <20140801060506.GA71116@FreeBSD.org> <53DB3021.7010909@marino.st>
 <20140801062047.GC71116@FreeBSD.org>
In-Reply-To: <20140801062047.GC71116@FreeBSD.org>
X-Enigmail-Version: 1.6
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Mailman-Approved-At: Fri, 01 Aug 2014 12:11:26 +0000
Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>,
 Max Brazhnikov <makc@freebsd.org>, Antoine Brodin <antoine@FreeBSD.org>,
 "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>,
 William Grzybowski <wg@freebsd.org>,
 "ports-committers@freebsd.org" <ports-committers@freebsd.org>,
 Mathieu Arnold <mat@freebsd.org>, Adam Weinberger <adamw@adamw.org>
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Aug 2014 06:26:23 -0000



On 8/1/2014 08:20, Alexey Dokuchaev wrote:
> On Fri, Aug 01, 2014 at 08:13:53AM +0200, John Marino wrote:
>> logic flaw: You can't just replace "/" with "-" or "_" without altering
>> "-" or "_" in the filename.
>>
>> example, given these files:
>>   ${WRKSRC}/alpha-bravo
>>   ${WRKSRC}/alpha/bravo
>>
>> if you replace "/" with "-", both have the same suggested patch name.
>> You need to alter the hyphen in alpha-bravo first.
> 
> Basically right now one patch will overwrite another conflicting one, which
> ever comes first.  I think I can add a check beforea > $${OUT} and issue an
> error and refuse to overwrite a file, or maybe just warn.  Which you prefer?
> 

Neither.  I prefer the original character escaped with itself  You may
not like this, but something like:

patch-alpha--bravo
patch-alpha-bravo

In the case of
   ${WRKSRC}/alpha_bravo
   ${WRKSRC}/alpha/bravo
using "_" as the separator, something like:

patch-alpha__bravo
patch-alpha_bravo


Thoughts?  any potential of overwritting is bad.

John