From owner-freebsd-bugs@FreeBSD.ORG Wed Nov 5 08:00:42 2003 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 55D6C16A4CE for ; Wed, 5 Nov 2003 08:00:42 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 84E7F44001 for ; Wed, 5 Nov 2003 08:00:38 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id hA5G0cFY051398 for ; Wed, 5 Nov 2003 08:00:38 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id hA5G0crX051395; Wed, 5 Nov 2003 08:00:38 -0800 (PST) (envelope-from gnats) Resent-Date: Wed, 5 Nov 2003 08:00:38 -0800 (PST) Resent-Message-Id: <200311051600.hA5G0crX051395@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Alexander Nedotsukov Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BA09616A4CE for ; Wed, 5 Nov 2003 07:53:41 -0800 (PST) Received: from bbnest.net (t116213.ap.plala.or.jp [220.220.116.213]) by mx1.FreeBSD.org (Postfix) with ESMTP id AD92D43FE3 for ; Wed, 5 Nov 2003 07:53:40 -0800 (PST) (envelope-from bland@mail.ru) Received: from bbnest.net (bland@localhost [127.0.0.1]) by bbnest.net (8.12.10/8.12.10) with ESMTP id hA5FrdGj001490 for ; Thu, 6 Nov 2003 00:53:39 +0900 (JST) (envelope-from bland@mail.ru) Received: (from bland@localhost) by bbnest.net (8.12.10/8.12.10/Submit) id hA5Frd6j001489; Thu, 6 Nov 2003 00:53:39 +0900 (JST) (envelope-from bland) Message-Id: <200311051553.hA5Frd6j001489@bbnest.net> Date: Thu, 6 Nov 2003 00:53:39 +0900 (JST) From: Alexander Nedotsukov To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: misc/58971: bug in libusbhid descriptor parser code. X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Alexander Nedotsukov List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Nov 2003 16:00:42 -0000 >Number: 58971 >Category: misc >Synopsis: bug in libusbhid descriptor parser code. >Confidential: no >Severity: serious >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Nov 05 08:00:38 PST 2003 >Closed-Date: >Last-Modified: >Originator: Alexander Nedotsukov >Release: FreeBSD 5.1-CURRENT i386 >Organization: >Environment: System: FreeBSD bbnest.net 5.1-CURRENT FreeBSD 5.1-CURRENT #4: Mon Nov 3 16:13:21 JST 2003 bland@bbnest.net:/usr/obj/usr/src/sys/BBNEST i386 >Description: According to specs "Report Size" is global item attribute therefore it should not be cleared in hid_clear_local() wich supposed to clear local attributes only. I have usb joystick wich report descriptor can not be properly parsed due this bug. >How-To-Repeat: >Fix: Apply the patch attached. --- libusbhid.patch begins here --- Index: parse.c =================================================================== RCS file: /home/ncvs/src/lib/libusbhid/parse.c,v retrieving revision 1.8 diff -u -p -r1.8 parse.c --- lib/libusbhid/parse.c 9 Apr 2003 01:52:48 -0000 1.8 +++ lib/libusbhid/parse.c 29 Oct 2003 05:51:12 -0000 @@ -86,7 +86,6 @@ hid_clear_local(hid_item_t *c) c->string_minimum = 0; c->string_maximum = 0; c->set_delimiter = 0; - c->report_size = 0; } hid_data_t --- libusbhid.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: