From owner-svn-src-stable@FreeBSD.ORG  Tue Apr  7 17:45:53 2009
Return-Path: <owner-svn-src-stable@FreeBSD.ORG>
Delivered-To: svn-src-stable@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
	id 877E2106566C; Tue,  7 Apr 2009 17:45:53 +0000 (UTC)
Date: Tue, 7 Apr 2009 17:45:53 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Maksim Yevmenkin <emax@FreeBSD.org>
Message-ID: <20090407174553.GA33627@FreeBSD.org>
References: <200904071629.n37GTowo014360@svn.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <200904071629.n37GTowo014360@svn.freebsd.org>
User-Agent: Mutt/1.4.2.1i
Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org, svn-src-stable-7@freebsd.org
Subject: Re: svn commit: r190808 - stable/7/etc/rc.d
X-BeenThere: svn-src-stable@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for all the -stable branches of the src tree
	<svn-src-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-stable>, 
	<mailto:svn-src-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-stable>
List-Post: <mailto:svn-src-stable@freebsd.org>
List-Help: <mailto:svn-src-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-stable>,
	<mailto:svn-src-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Apr 2009 17:45:54 -0000

On Tue, Apr 07, 2009 at 04:29:50PM +0000, Maksim Yevmenkin wrote:
> Author: emax
> Date: Tue Apr  7 16:29:50 2009
> New Revision: 190808
> URL: http://svn.freebsd.org/changeset/base/190808
> 
>  ipfw_start()
>  {
> +	local   _firewall_type
> +
> +	_firewall_type=$1 

Why extra tab and not simply "local _firewall_type=$1"?

> -run_rc_command "$1"
> +run_rc_command $*

I haven't looked at the implementation of run_rc_command but "$1"
suggests it should be "$@" instead.

./danfe