From owner-cvs-sys Tue Oct 31 21:56:50 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id VAA23214 for cvs-sys-outgoing; Tue, 31 Oct 1995 21:56:50 -0800 Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id VAA23199 ; Tue, 31 Oct 1995 21:56:40 -0800 Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.9/8.6.9) id QAA17404; Wed, 1 Nov 1995 16:55:00 +1100 Date: Wed, 1 Nov 1995 16:55:00 +1100 From: Bruce Evans Message-Id: <199511010555.QAA17404@godzilla.zeta.org.au> To: davidg@Root.COM, peter@jhome.dialix.com Subject: Re: cvs commit: src/sys/kern tty_subr.c Cc: CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk >I used to have this problem occasionally with the specialix driver, and in >the end the interrupt routine had to do a lot of tests to attempt to >intuit whether or not he cblocks were currently reserved or not. The That's why I don't like silently ignoring the problem. Reporting it nastily should have been good for getting drivers fixed. si.c was relying on TS_CONNECTED but TS_CONNECTED isn't set quite right for it. TS_CONNECTED shouldn't be set in ttymodem() unless TS_ISOPEN is set. If you fix this, then change the recent fix to ttyopen() to set TS_CONNECTED if carrier is on as well as if CLOCAL is set. Bruce