From owner-cvs-src@FreeBSD.ORG Thu Jun 22 14:05:29 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 020BA16A484; Thu, 22 Jun 2006 14:05:28 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from transport.cksoft.de (transport.cksoft.de [62.111.66.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7AC3B43D80; Thu, 22 Jun 2006 14:05:11 +0000 (GMT) (envelope-from bz@FreeBSD.org) Received: from transport.cksoft.de (localhost [127.0.0.1]) by transport.cksoft.de (Postfix) with ESMTP id 27A651FF915; Thu, 22 Jun 2006 16:05:09 +0200 (CEST) Received: by transport.cksoft.de (Postfix, from userid 66) id A50FD1FF90C; Thu, 22 Jun 2006 16:05:05 +0200 (CEST) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id F20E84448D6; Thu, 22 Jun 2006 14:04:27 +0000 (UTC) Date: Thu, 22 Jun 2006 14:04:27 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: Hajimu UMEMOTO In-Reply-To: <200606221322.k5MDMs2X065252@repoman.freebsd.org> Message-ID: <20060622140253.X60374@maildrop.int.zabbadoz.net> References: <200606221322.k5MDMs2X065252@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Virus-Scanned: by AMaViS cksoft-s20020300-20031204bz on transport.cksoft.de Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet ip_fw2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jun 2006 14:05:29 -0000 On Thu, 22 Jun 2006, Hajimu UMEMOTO wrote: > ume 2006-06-22 13:22:54 UTC > > FreeBSD src repository > > Modified files: > sys/netinet ip_fw2.c > Log: > - Pullup even when the extention header is unknown, to prevent > infinite loop with net.inet6.ip6.fw.deny_unknown_exthdrs=0. > - Teach ipv6 and ipencap as they appear in an IPv4/IPv6 over IPv6 > tunnel. > - Test the next extention header even when the routing header type > is unknown with net.inet6.ip6.fw.deny_unknown_exthdrs=0. @@ -2189,7 +2189,10 @@ do { \ case IPPROTO_ROUTING: /* RFC 2460 */ PULLUP_TO(hlen, ulp, struct ip6_rthdr); - if (((struct ip6_rthdr *)ulp)->ip6r_type != 0) { + switch (((struct ip6_rthdr *)ulp)->ip6r_type) { + case 0: I think you are missing a ulp = NULL; here? + break; + default: printf("IPFW2: IPV6 - Unknown Routing " "Header type(%d)\n", ((struct ip6_rthdr *)ulp)->ip6r_type); -- Bjoern A. Zeeb bzeeb at Zabbadoz dot NeT