From nobody Fri Jun 5 19:38:10 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gXBYZ6dp7z6gPBc for ; Fri, 05 Jun 2026 19:38:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gXBYZ5vyfz3DNC for ; Fri, 05 Jun 2026 19:38:10 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780688290; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dV20vK4+b4E+E2TvvCRhfSMPitGkT9z43XTi4KSbrkc=; b=uGgCGeh7rEGqq2fNlzeRr2NfBYpWgXuXmZT7aIwZwNbQoqhW3WCigSyQT/eaH9U8tCaKfl 8MzffqjdZEBUDtXmDF4iDRZY6esKATGIn96U0sQggbcYGUa+v1YCsWyfamO/EGiP2HudD5 UmCZBUQad5PPGqHDBZHt3aWYT4zoIv66/e7blae+8V6ORkuJ3NaUZFBdMCEKRcWo39zscy tJuw81KXMYLCNVsSrVtulcOP/0XddgDOzApWsm/eyWQK8gVllIxVtERoyWRhGEtrPpkK1K VG0g1zKekm6XvWvkzPDZvcaqJIU4LU45/qLavx0vxmCjWJcdSKc/HyOJD+31FA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1780688290; a=rsa-sha256; cv=none; b=w1LpRcPZdZkOInMfxRWUee1nZUNr9oAK7Lq9AR8BUuXu3cNFjVIDQElRM3IKCH1caBpdcE Q09+7r6KNR7g+o5MTaYzweeKn0MEMN6xGx7syP4J56loVsm+JZEBFuYRV5BjRUg6chfZf6 oHzByAYg7u1gbaLgxBcluJPUFf9wjsOq4Gxr5ONuVXCIGWpvrw4yEl7Y1vjmpD05WtlOKg 7qEZMjF1rfg1paUM24aOWIJ6Lw0lwIfd5+qqitiBTaKQZM+BI5ONmJZPKRMQrsHYhy+QzE w7N8wxyn6dgBzRhALU+iiMKopVus6Zha5Yo3UuXQRJXkm9yqrWHWGH7SQVVKHQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780688290; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dV20vK4+b4E+E2TvvCRhfSMPitGkT9z43XTi4KSbrkc=; b=I0ImoopxP+Ps8auiGEayAOyzXQhUMQ7lCWTKmi8NL83hl0mE0B/AJdIAlMW4ZRqaeHKdjW TzO4MNHD953jW5c9508EQOcu6SClxkpMf24q+xYyldnASje50JWILF4VmSjBNv7/hEoKR7 HgqStgQDT577A4RWKJAtyu2lw7ctSvhFduMOE2dxu5vp4z19w3niYScU6+YS0iFyPkOcEZ 8jL+pKDGTYU5EG1yg6si/pHJQKbsyNApJEx7H3EBGtb2TExtZpHjsjRJ/qviI9Lj7+niz3 lc8XjI8KYmWhJ8FKjdkRacA4hMUmsxCkMnoTfDI5dD34fg29T5UR7kbdtNlfHA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gXBYZ5FqvzkSl for ; Fri, 05 Jun 2026 19:38:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 33b03 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 05 Jun 2026 19:38:10 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Ed Maste Subject: git: 28833ade34e4 - stable/14 - netlink: Fix lock leak in nl_find_nhop List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 28833ade34e4eabbbbf985217e552ac589fb9329 Auto-Submitted: auto-generated Date: Fri, 05 Jun 2026 19:38:10 +0000 Message-Id: <6a2325a2.33b03.1c2a5a7@gitrepo.freebsd.org> The branch stable/14 has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=28833ade34e4eabbbbf985217e552ac589fb9329 commit 28833ade34e4eabbbbf985217e552ac589fb9329 Author: Ed Maste AuthorDate: 2026-05-21 21:14:41 +0000 Commit: Ed Maste CommitDate: 2026-06-05 19:37:58 +0000 netlink: Fix lock leak in nl_find_nhop Reviewed by: bz, pouria Fixes: 7e5bf68495cc ("netlink: add netlink support") Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D57156 (cherry picked from commit d66fec481bfd65cbabb6c12a410d76843e76083e) (cherry picked from commit ab599e44dba31d7b002aed8c71242e06d992b21a) --- sys/netlink/route/nexthop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/netlink/route/nexthop.c b/sys/netlink/route/nexthop.c index 0d6bb5c9ec84..e7f08f2f8f3a 100644 --- a/sys/netlink/route/nexthop.c +++ b/sys/netlink/route/nexthop.c @@ -174,7 +174,7 @@ nl_find_nhop(uint32_t fibnum, int family, uint32_t uidx, CHT_SLIST_FIND_BYOBJ(&ctl->un_head, unhop, &key, unhop); if (unhop != NULL) { struct nhop_object *nh = unhop->un_nhop; - UN_RLOCK(ctl); + UN_RUNLOCK(ctl); *perror = 0; nhop_ref_any(nh); return (nh);