Date: Sat, 16 Jun 2012 20:30:10 +0200 From: Kurt Jaeger <fbsd-ports@opsec.eu> To: FreeBSD-gnats-submit@FreeBSD.org Cc: gnome@FreeBSD.org, esr@thyrsus.com Subject: ports/169163: [patch update] giflib-related fix for the call to PrintGifError Message-ID: <E1SfxlC-0003CA-BZ@fa8.opsec.eu> Resent-Message-ID: <201206161830.q5GIUL8t041872@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 169163
>Category: ports
>Synopsis: [patch update] giflib-related fix for the call to PrintGifError
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: update
>Submitter-Id: current-users
>Arrival-Date: Sat Jun 16 18:30:19 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: Kurt Jaeger
>Release: FreeBSD 8.3-RELEASE amd64
>Organization:
-
>Environment:
System: FreeBSD fa8.opsec.eu 8.3-RELEASE FreeBSD 8.3-RELEASE #0: Mon Apr 9 21:23:18 UTC 2012 root@mason.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64
>Description:
imlib uses giflib, which was recently updated to 4.2.0
During that update, PrintGifError(), a published interface from
giflib, was deleted.
Other ports (e.g. magicpoint) require imlib and PrintGifError()
and fail to compile.
This patch might not be the perfect solution (should that one
be provided by giflib ?), but it seems to work 8-}
>How-To-Repeat:
see above
>Fix:
diff -r -u -N graphics/imlib/Makefile /usr/home/pi/myp/graphics/imlib/Makefile
--- graphics/imlib/Makefile 2012-06-01 23:28:59.000000000 +0200
+++ /usr/home/pi/myp/graphics/imlib/Makefile 2012-06-16 20:24:29.000000000 +0200
@@ -8,7 +8,7 @@
PORTNAME= imlib
PORTVERSION= 1.9.15
-PORTREVISION= 14
+PORTREVISION= 15
CATEGORIES= graphics
MASTER_SITES= GNOME
DIST_SUBDIR= gnome
diff -r -u -N graphics/imlib/files/patch-PrintGifError /usr/home/pi/myp/graphics/imlib/files/patch-PrintGifError
--- graphics/imlib/files/patch-PrintGifError 1970-01-01 01:00:00.000000000 +0100
+++ /usr/home/pi/myp/graphics/imlib/files/patch-PrintGifError 2012-06-16 20:20:21.000000000 +0200
@@ -0,0 +1,21 @@
+--- Imlib/load.c-orig 2012-06-16 20:19:27.000000000 +0200
++++ Imlib/load.c 2012-06-16 20:19:56.000000000 +0200
+@@ -420,6 +420,18 @@
+ #endif /* HAVE_LIBTIFF */
+
+ #ifdef HAVE_LIBGIF
++
++static void
++PrintGifError(void)
++{
++ char *Err = GifErrorString();
++
++ if (Err != NULL)
++ fprintf(stderr, "\nGIF-LIB error: %s.\n", Err);
++ else
++ fprintf(stderr, "\nGIF-LIB undefined error %d.\n", GifError());
++}
++
+ unsigned char *
+ _LoadGIF(ImlibData * id, FILE *f, int *w, int *h, int *t)
+ {
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E1SfxlC-0003CA-BZ>