From owner-dev-commits-src-all@freebsd.org Wed May 19 18:32:05 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9EEE06489C8 for ; Wed, 19 May 2021 18:32:05 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FlhKx3pPVz3LlJ for ; Wed, 19 May 2021 18:32:05 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wr1-f45.google.com with SMTP id h4so15002673wrt.12 for ; Wed, 19 May 2021 11:32:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=gt///jaZUlH+E+/C4Hd30zXGPOifU0F8mwghNacnRqI=; b=rSt3PHBXwwE/Mq/HLiKbCzulGHY/qpjqxL/BPEdiNVFJNPfHLVkAoNVQ6PZyzvukju veaSrcoDPHIF4athKRjOjYLKJyTjoCaBzPHOypUwZoCeH8oWubrrzVeEVHM5IEsRYLb7 Y7VRizX4ObGfb/zTBZ0g1iOBRGZaU4uCuY+EyMXXiYwpmUVhPDrMu8wrkyFJZs2OAIC2 SaurnlkOy8GDZuhB9Hpy1E40BjjAg63Jf6z1zhuZaYa0HP8xXFvrpkwbG8Mq/fiUP0ie PbLX1qZ1c4rv4619Jusxi4y8IqE7+tOjlPNyOnwDr4gwGKVqGIUl5ICwisdu0GT5ls1W tsYw== X-Gm-Message-State: AOAM531V9lyEzetvGybuT6bPL5o7h0v7iz1pJ77Iu8fSW4nh+Z++Qgqg c+BEm4BFWgdvAxU/WWf41KzYxg== X-Google-Smtp-Source: ABdhPJz6qDs+m8i81DAguYdV5088Ok5JFOUiiv+PJsogakJOE2+i2/a7Gp6bQ66xJtFEZ1B2oTeEGw== X-Received: by 2002:a5d:5301:: with SMTP id e1mr326355wrv.36.1621449124025; Wed, 19 May 2021 11:32:04 -0700 (PDT) Received: from [192.168.150.48] (trinity-students-nat.trin.cam.ac.uk. [131.111.193.104]) by smtp.gmail.com with ESMTPSA id r14sm174247wrx.74.2021.05.19.11.32.03 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 May 2021 11:32:03 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Subject: Re: git: 086feed850c3 - main - md5: Create md5sum, etc compatible programs From: Jessica Clarke In-Reply-To: <202105191744.14JHi6fA008046@gitrepo.freebsd.org> Date: Wed, 19 May 2021 19:32:02 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <9BE6FB36-5958-4220-9C95-86DED767F6ED@freebsd.org> References: <202105191744.14JHi6fA008046@gitrepo.freebsd.org> To: Warner Losh X-Mailer: Apple Mail (2.3654.60.0.2.21) X-Rspamd-Queue-Id: 4FlhKx3pPVz3LlJ X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 May 2021 18:32:05 -0000 On 19 May 2021, at 18:44, Warner Losh wrote: >=20 > The branch main has been updated by imp: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D086feed850c31c278f25c958b97992d0= 24139896 >=20 > commit 086feed850c31c278f25c958b97992d024139896 > Author: Warner Losh > AuthorDate: 2021-05-19 17:26:20 +0000 > Commit: Warner Losh > CommitDate: 2021-05-19 17:41:53 +0000 >=20 > md5: Create md5sum, etc compatible programs >=20 > On Linux, there's a similar set of programs to ours, but that end = in the > letters 'sum'. These act basically like FreeBSD versions run with = the -r > option. Add code so that when the program ends in 'sum' you get the > linux -r behavior. This is enough to make most things that use = sha*sum > work correctly (the -c / --check options, as well as the long args = are > not implemented). When running with the -sum programs, ignore -t = instead > of running internal speed tests and make -c an error. >=20 > Reviewed by: sef, and kp and allanjude (earlier version) > Relnotes: yes > Sponsored by: Netflix > Differential Revision: https://reviews.freebsd.org/D30309 > --- > diff --git a/sbin/md5/md5.c b/sbin/md5/md5.c > index 96dfcede9711..4381ef124c7b 100644 > --- a/sbin/md5/md5.c > +++ b/sbin/md5/md5.c > @@ -177,13 +177,32 @@ main(int argc, char *argv[]) > char buf[HEX_DIGEST_LENGTH]; > size_t len; > unsigned digest; > - const char* progname; > + char *progname; > + bool gnu_emu =3D false; This file doesn=E2=80=99t currently include stdbool.h explicitly, and = apparently that is not implicitly included by any of the headers on Linux (and I cannot = work out where it comes from on FreeBSD). Could you please add the explicit = include to fix cross-building? Thanks, Jess