From owner-freebsd-hackers Sat Nov 11 16:47:10 2000 Delivered-To: freebsd-hackers@freebsd.org Received: from mail.gmx.net (pop.gmx.net [194.221.183.20]) by hub.freebsd.org (Postfix) with SMTP id D6F3137B479 for ; Sat, 11 Nov 2000 16:47:03 -0800 (PST) Received: (qmail 22322 invoked by uid 0); 12 Nov 2000 00:47:00 -0000 Received: from p3ee21428.dip.t-dialin.net (HELO forge.local) (62.226.20.40) by mail.gmx.net (mail02) with SMTP; 12 Nov 2000 00:47:00 -0000 Received: from thomas by forge.local with local (Exim 3.12 #1 (Debian)) id 13ulIK-0003Iu-00 for ; Sun, 12 Nov 2000 01:46:52 +0100 Date: Sun, 12 Nov 2000 01:46:52 +0100 From: Thomas Moestl To: freebsd-hackers@freebsd.org Subject: Re: [PATCH] per-packet UDP source address selection for sendmsg Message-ID: <20001112014652.A12685@forge.local> Mail-Followup-To: Thomas Moestl , freebsd-hackers@freebsd.org References: <20001111183857.A9781@forge.local> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20001111183857.A9781@forge.local>; from tmoestl@gmx.net on Sat, Nov 11, 2000 at 06:38:57PM +0100 Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > As this is my first kernel patch, could someone please give it a quick > look before I submit it, so that I can be sure that it contains no stupid > glitches? > [...] > + bzero(&src, sizeof(src)); > + src.sin_family = AF_INET; > + src.sin_port = inp->inp_lport; > + src.sin_addr = *(struct in_addr *)CMSG_DATA(cm); > + bound = 1; Except of course forgetting to set src.sin_len :( Thomas To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message