From owner-freebsd-current@FreeBSD.ORG Thu Apr 8 18:03:40 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4F56C106566B; Thu, 8 Apr 2010 18:03:40 +0000 (UTC) (envelope-from yanefbsd@gmail.com) Received: from mail-qy0-f181.google.com (mail-qy0-f181.google.com [209.85.221.181]) by mx1.freebsd.org (Postfix) with ESMTP id B81048FC12; Thu, 8 Apr 2010 18:03:39 +0000 (UTC) Received: by qyk11 with SMTP id 11so1791273qyk.13 for ; Thu, 08 Apr 2010 11:03:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:received:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=Vdy2xzS0Nuv186QeGmCiyafGhTCP8sEhkKK3MKzpD2k=; b=V+An6HkQe5gvd9H5syzzd6qONwj/XvUUucf9fRY2DjiHzWZQ5ehKa46DGo571G2FfQ IElVf05oB3RErv0+NJG+j2wOi/BYW8hRc7i8ZZG/H0GVso/IO6QgrO1YpDqWMn4dW7e0 fkokxZRAJrOB+zHNwxhzx7PeKeeLh3/TKoR7o= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=DY4SW7Urxh2PD/ECY08611TauT/G2QUqkouPSym7rxJb9oLvRJVYU17/XOErJM/HzO JeAMB4zz0BsfhjaHJrvQO1TO755DmZOn9KRalOElInokyW8HE9wI5RyGJVDmtemH6vF/ yUEfZTv2zz0aKAnsfcWABuaOEykUt0a4u5Pzo= MIME-Version: 1.0 Received: by 10.229.33.72 with HTTP; Thu, 8 Apr 2010 11:03:37 -0700 (PDT) In-Reply-To: <86r5mqt4aj.fsf@ds4.des.no> References: <55861270658151@web135.yandex.ru> <20100408103809.13496s9i6ny03ocg@webmail.leidinger.net> <867hoi8gbl.fsf@ds4.des.no> <201004080849.12151.jhb@freebsd.org> <86r5mqt4aj.fsf@ds4.des.no> Date: Thu, 8 Apr 2010 11:03:37 -0700 Received: by 10.229.241.82 with SMTP id ld18mr51884qcb.60.1270749818090; Thu, 08 Apr 2010 11:03:38 -0700 (PDT) Message-ID: From: Garrett Cooper To: =?ISO-8859-1?Q?Dag=2DErling_Sm=F8rgrav?= Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Bruce Cran , freebsd-geom@freebsd.org, Teske , Randi Harper , freebsd-current@freebsd.org, "Andrey V. Elsukov" , Alexander Leidinger Subject: Re: [RFC] Rewriting sade(8) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Apr 2010 18:03:40 -0000 2010/4/8 Dag-Erling Sm=F8rgrav : > John Baldwin writes: >> Dag-Erling Sm=F8rgrav writes: >> > My suggestion is to add a "sysinstall mode" to sade where it >> > operates under certain (minor) constraints and reports what it did >> > in a format that sysinstall can parse, so sysinstall can just >> > fork-exec sade instead of duplicating the code. >> Actually, I would rather have sysinstall just invoke sade to do the >> disk related stuff. > > ...which is exactly what I said - but in the sysinstall case, you may > want to ask some additional questions ("are you sure you want to proceed > without a swap partition?") or place some additional constraints (such > as "don't allow the user to mount something on top of /mnt or /rescue"), > and sysinstall needs to know the outcome. If the user shoots him or herself in the foot, that's their own problem. They should at least read hier(7) or ask a question on questions@ beforehand. As long as the auto-partitioner is correct, it's fine. Complicating the tool with a lot of unnecessary criteria will just produce unnecessary bloat. Thanks, -Garrett