From owner-freebsd-stable@FreeBSD.ORG Thu Feb 24 12:51:50 2005 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EA95716A4CF for ; Thu, 24 Feb 2005 12:51:50 +0000 (GMT) Received: from ares.wolfpond.org (ns1.wolfpond.org [62.212.96.219]) by mx1.FreeBSD.org (Postfix) with ESMTP id 02B1643D45 for ; Thu, 24 Feb 2005 12:51:49 +0000 (GMT) (envelope-from ftigeot@wolfpond.org) Received: from aoi.wolfpond.org (aoi.wolfpond.org [IPv6:2001:7a8:24db:1:20c:76ff:feb4:27e1]) by ares.wolfpond.org (8.13.3/8.13.3) with ESMTP id j1OCpf7T019911; Thu, 24 Feb 2005 13:51:41 +0100 (CET) (envelope-from ftigeot@aoi.wolfpond.org) Received: from aoi.wolfpond.org (localhost [127.0.0.1]) by aoi.wolfpond.org (8.13.3/8.13.1) with ESMTP id j1OCpowU096619; Thu, 24 Feb 2005 13:51:50 +0100 (CET) (envelope-from ftigeot@aoi.wolfpond.org) Received: (from ftigeot@localhost) by aoi.wolfpond.org (8.13.3/8.13.1/Submit) id j1OCpnTG096618; Thu, 24 Feb 2005 13:51:49 +0100 (CET) (envelope-from ftigeot) Date: Thu, 24 Feb 2005 13:51:49 +0100 From: Francois Tigeot To: Jeff Roberson Message-ID: <20050224125148.GA22855@aoi.wolfpond.org> References: <20050224031645.A86246@mail.chesapeake.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050224031645.A86246@mail.chesapeake.net> User-Agent: Mutt/1.4.2.1i cc: stable@freebsd.org Subject: Re: Merging phk's filedesc cleanup and lock pushdown. X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Feb 2005 12:51:51 -0000 On Thu, Feb 24, 2005 at 03:18:49AM -0500, Jeff Roberson wrote: > I am going to MFC phk's filedesc related work in the next few days. This > is required if I am ever to merge the vfs smp changes. I have a patch > available at: > > http://www.chesapeake.net/~jroberson/fdesc.patch > > I'd appreciate it if anyone who can would test this. It has been running > on current for 3-4 months, depending on the bit, but there's always a > chance of a botched merge. World doesn't build with this patch: cc -O -pipe -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -c /usr/src/usr.bin/fstat/fstat.c /usr/src/usr.bin/fstat/fstat.c: In function `dofiles': /usr/src/usr.bin/fstat/fstat.c:325: error: storage size of 'filed0' isn't known /usr/src/usr.bin/fstat/fstat.c:363: error: `NDFILE' undeclared (first use in this function) /usr/src/usr.bin/fstat/fstat.c:363: error: (Each undeclared identifier is reported only once /usr/src/usr.bin/fstat/fstat.c:363: error: for each function it appears in.) /usr/src/usr.bin/fstat/fstat.c:325: warning: unused variable `filed0' *** Error code 1 Stop in /usr/src/usr.bin/fstat. *** Error code 1 Stop in /usr/src/usr.bin. *** Error code 1 Stop in /usr/src. *** Error code 1 Stop in /usr/src. *** Error code 1 Stop in /usr/src. nice make buildworld 1209,00s user 251,75s system 78% cpu 31:04,65 total This machine is an amd64 5.3-STABLE host. The same sources build nicely without the patch. -- Francois Tigeot