From nobody Tue Apr 4 10:23:34 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PrP481krQz43Ld6; Tue, 4 Apr 2023 10:23:36 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [IPv6:2607:f8b0:4864:20::236]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PrP4803RSz43vt; Tue, 4 Apr 2023 10:23:36 +0000 (UTC) (envelope-from mjguzik@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-oi1-x236.google.com with SMTP id bm2so23869742oib.4; Tue, 04 Apr 2023 03:23:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680603815; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=LGk8VEae/2X7oodL9AEr2U1Wz3RgsmO4/d7/AKns+Qw=; b=XWmCv86FfcPibc57QGr1ptoU5t0KevhsOgCrmUGPtB64sdGRDdWugtED+mshqAJhoM TN/HWcXSUIJRqMwAw362vwLw9FE16seKZWnvhnzjJQsn2rAqZyx3RFMNDdf6Liorx8tL 2kM1/rRx5hEgwr5NeWf/t+inc8p6Gc/ySZfArvvUXu+kOO3Qv6xYk145jJns0PTmdXqq 7Z4DbJ/V0Gij74ulKaO8ZvUqZYXnp3qw76TDX00I5++26dBhhclhBIwYFLqYe6bHpP9l ODDzlgPBFNu25fpL7++muVRz2JQZ3aVm15TzRdV+BTJIT1lE0cDPpBjxZmsW6/XRSNAl j6BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680603815; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LGk8VEae/2X7oodL9AEr2U1Wz3RgsmO4/d7/AKns+Qw=; b=XkKFDwH79zepbzGZnxmdebFSKwwJOcsfnAbOnzUi3RUbdRXHV2zAgc6TP6ppofUcVn 1DEPth5wEoUOjYMXfUVdbv7xg4gUrOnHSC8QMnutSJQALnffDyPc1HEQ0gQpgde+6wSV CyLwtQTc+yQSoNtey+o+MFPfEOjcS8fszOd7wqsYHeW9DhDf3DDuk5nvxCNja8l+Eexj uQoxMf7Uu0ZRQ9lg9CCVA6LgCjhedm6b1tx1JgrLsTamyWPMmpgOVLuGCsQQT2gG49o6 G0dTx3/EDM39FNCsHalfbaojxQ+tOoDnhUZX4YgWLJdogsNW4EdeEL13/da0sdMz9lKX aa0Q== X-Gm-Message-State: AAQBX9d7E+y58kTlMgi/HePjqx02h8cdW67lMWLxc4PndPN7gIi8pX9F q/1vxkVg32U3+UooUqnZgun974VxMkWvQuQ8kJi6KspX X-Google-Smtp-Source: AKy350aw7WumdYjg/CUz0sALNx78LZMgtu80F2Cu2cMDMCNovDk0pqOchgzS3ChMHCKb9R9lXqqOYETDYTdomUQmaXU= X-Received: by 2002:aca:bf02:0:b0:387:251b:71fa with SMTP id p2-20020acabf02000000b00387251b71famr701080oif.4.1680603814971; Tue, 04 Apr 2023 03:23:34 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Received: by 2002:ac9:570a:0:b0:49c:b071:b1e3 with HTTP; Tue, 4 Apr 2023 03:23:34 -0700 (PDT) In-Reply-To: <202304041015.334AF7oF006042@critter.freebsd.dk> References: <202304040740.3347eiU8033699@gitrepo.freebsd.org> <202304040959.3349xqqB005509@critter.freebsd.dk> <202304041015.334AF7oF006042@critter.freebsd.dk> From: Mateusz Guzik Date: Tue, 4 Apr 2023 12:23:34 +0200 Message-ID: Subject: Re: git: 643336549081 - main - If copy_file_range(2) fails with EXDEV, use fall-back. To: Poul-Henning Kamp Cc: Alexey Dokuchaev , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4PrP4803RSz43vt X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On 4/4/23, Poul-Henning Kamp wrote: > -------- > Alexey Dokuchaev writes: > >> Okay, but did it leave an empty file, I wonder? > > I didn't check, but it probably would, because cp(1) must have opened > and created the destination in order to call copy_file_range(2). > > PS: I'll note that EXDEV is not a documented return value from > copy_file_range(2), and my surprise that cp(1) did not revert > to the fall-back, no matter why copy_file_range(2) failed. > that's a new one and should not be happening, something is borked in the kernel -- cross device copies *are* supported i'll look into it later -- Mateusz Guzik