From owner-p4-projects@FreeBSD.ORG  Sat Jan  6 19:34:03 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 5807216A47B; Sat,  6 Jan 2007 19:34:03 +0000 (UTC)
X-Original-To: perforce@FreeBSD.org
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 36EB216A403
	for <perforce@FreeBSD.org>; Sat,  6 Jan 2007 19:34:03 +0000 (UTC)
	(envelope-from gonzo@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41])
	by mx1.freebsd.org (Postfix) with ESMTP id 2622013C428
	for <perforce@FreeBSD.org>; Sat,  6 Jan 2007 19:34:03 +0000 (UTC)
	(envelope-from gonzo@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id l06JY36t049446
	for <perforce@FreeBSD.org>; Sat, 6 Jan 2007 19:34:03 GMT
	(envelope-from gonzo@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.6/8.13.4/Submit) id l06JY2Uv049443
	for perforce@freebsd.org; Sat, 6 Jan 2007 19:34:02 GMT
	(envelope-from gonzo@FreeBSD.org)
Date: Sat, 6 Jan 2007 19:34:02 GMT
Message-Id: <200701061934.l06JY2Uv049443@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	gonzo@FreeBSD.org using -f
From: Oleksandr Tymoshenko <gonzo@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 112616 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 06 Jan 2007 19:34:03 -0000

http://perforce.freebsd.org/chv.cgi?CH=112616

Change 112616 by gonzo@gonzo_hq on 2007/01/06 19:33:17

	o Make stack 64-bit aligned: required by ABI to pass 
	    64-bits arguments.

Affected files ...

.. //depot/projects/mips2/src/lib/csu/mips/crt1.c#4 edit

Differences ...

==== //depot/projects/mips2/src/lib/csu/mips/crt1.c#4 (text+ko) ====

@@ -80,15 +80,20 @@
 "	.globl	_start		\n"
 "	_start:			\n"
 "	/* Get argc, argv from stack */	\n"
+"	/* lw	a0, 0(sp)     */\n"
+"	/* move	a1, sp        */\n"
+"	/* addu	a1, 4         */\n"
 "				\n"
-"	/* lw	a0, 0(sp)   */\n"
-"	/* move	a1, sp        */\n"
-"	/* addu	a1, 4    */\n"
+"	/* Stack should 8bytes aligned */\n"
+"	/* required by ABI to pass     */\n"
+"	/* 64-bits arguments           */\n"
+"	/* and	sp, ~8        */\n"
 "				\n"
 "	lw	$4, 0($29)	\n"
 "	move	$5, $29		\n"
 "	addu	$5, 4		\n"
-"	/* TODO: Ensure the stack is properly aligned before calling C code. */\n"
+"				\n"
+"	and	$29, 0xfffffff8	\n"
 "\n"
 "	j	 __start  ");
 /* ARGSUSED */