From owner-freebsd-ports-bugs@freebsd.org Mon Jul 30 07:24:02 2018 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AD5E9104D4D6 for ; Mon, 30 Jul 2018 07:24:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 496968BF70 for ; Mon, 30 Jul 2018 07:24:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 0E6A7104D4D5; Mon, 30 Jul 2018 07:24:02 +0000 (UTC) Delivered-To: ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F1495104D4D4 for ; Mon, 30 Jul 2018 07:24:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 91E5E8BF6D for ; Mon, 30 Jul 2018 07:24:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id C4BC91F6B7 for ; Mon, 30 Jul 2018 07:24:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w6U7O0Rt009823 for ; Mon, 30 Jul 2018 07:24:00 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w6U7O0dj009822 for ports-bugs@FreeBSD.org; Mon, 30 Jul 2018 07:24:00 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 230179] textproc/luaexpat: fails test script on lua 5.3 Date: Mon, 30 Jul 2018 07:23:59 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: andrew@tao11.riddles.org.uk X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: lx@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter flagtypes.name attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jul 2018 07:24:03 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D230179 Bug ID: 230179 Summary: textproc/luaexpat: fails test script on lua 5.3 Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: lx@FreeBSD.org Reporter: andrew@tao11.riddles.org.uk Flags: maintainer-feedback?(lx@FreeBSD.org) Assignee: lx@FreeBSD.org Created attachment 195622 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D195622&action= =3Dedit Makefile patch The supposed "fix" for luaexpat in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D224644 is incorrect, an= d this is easily demonstrated by running the test.lua script included in the module source. The most reasonable fix seems to be this (in addition to removing the incor= rect LUA_32BITS): MAKE_ARGS+=3D COMMON_CFLAGS=3D"-Wall" (i.e. removing options -g -O2 -ansi -pedantic -fPIC -DPIC from the makefile; -fPIC is added back from CFLAGS already, and debug/optimization flags are likewise supposed to come from the port CFLAGS.) Another option that works would be to use -std=3Dc99, but I think the above method is better (and I have checked that the test script runs ok on lua 5.1 and 5.2 still). Patch attached. (I also added a LICENSE=3DMIT - see the doc/us/license.html= in the distribution) --=20 You are receiving this mail because: You are the assignee for the bug.=