From owner-cvs-all Mon Jul 15 6: 3:37 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 15CBA37B406 for ; Mon, 15 Jul 2002 06:03:11 -0700 (PDT) Received: from mail.speakeasy.net (mail11.speakeasy.net [216.254.0.211]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1419B43E58 for ; Mon, 15 Jul 2002 06:03:10 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 16595 invoked from network); 15 Jul 2002 13:03:09 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail11.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 15 Jul 2002 13:03:09 -0000 Received: from laptop.baldwin.cx (laptop.baldwin.cx [192.168.0.4]) by server.baldwin.cx (8.11.6/8.11.6) with ESMTP id g6FD38048294; Mon, 15 Jul 2002 09:03:08 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200207142351.g6ENptlW038537@freefall.freebsd.org> Date: Mon, 15 Jul 2002 09:03:19 -0400 (EDT) From: John Baldwin To: Alan Cox Subject: RE: cvs commit: src/sys/alpha/alpha pmap.c src/sys/vm vm_page.c Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 14-Jul-2002 Alan Cox wrote: > alc 2002/07/14 16:51:55 PDT > > Modified files: > sys/alpha/alpha pmap.c > sys/vm vm_page.c > Log: > o Lock page queue accesses by vm_page_wire() that aren't > within a critical section. > o Assert that the page queues lock is held in vm_page_wire() > unless an Alpha. Even in a critical section you still need the lock to ensure you don't read stale data and to prevent others from writing to them out from under you. If the critical section in question is for pmap_growkernel(), then I think you can actually remove it anyways. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message