From owner-freebsd-i386@FreeBSD.ORG Mon Nov 17 01:30:02 2008 Return-Path: Delivered-To: freebsd-i386@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6059A1065673 for ; Mon, 17 Nov 2008 01:30:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 3D58D8FC0C for ; Mon, 17 Nov 2008 01:30:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id mAH1U1iU009935 for ; Mon, 17 Nov 2008 01:30:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id mAH1U1Ef009932; Mon, 17 Nov 2008 01:30:01 GMT (envelope-from gnats) Resent-Date: Mon, 17 Nov 2008 01:30:01 GMT Resent-Message-Id: <200811170130.mAH1U1Ef009932@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-i386@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Darren Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 23821106564A for ; Mon, 17 Nov 2008 01:22:55 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 12A478FC17 for ; Mon, 17 Nov 2008 01:22:55 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id mAH1MrkE081572 for ; Mon, 17 Nov 2008 01:22:53 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id mAH1Mr1s081571; Mon, 17 Nov 2008 01:22:53 GMT (envelope-from nobody) Message-Id: <200811170122.mAH1Mr1s081571@www.freebsd.org> Date: Mon, 17 Nov 2008 01:22:53 GMT From: Darren To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: i386/128931: src/sys/dev/puc/pucdata.c v1.51.2.3 breaks support for NetMos 4-port serial cards X-BeenThere: freebsd-i386@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: I386-specific issues for FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Nov 2008 01:30:02 -0000 >Number: 128931 >Category: i386 >Synopsis: src/sys/dev/puc/pucdata.c v1.51.2.3 breaks support for NetMos 4-port serial cards >Confidential: no >Severity: serious >Priority: low >Responsible: freebsd-i386 >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Nov 17 01:30:01 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Darren >Release: RELENG_6_3 >Organization: >Environment: FreeBSD [REDACTED] 6.3-RELEASE-p5 FreeBSD 6.3-RELEASE-p5 #2: Sun Nov 16 15:37:12 PST 2008 root@[REDACTED]:/usr/src/sys/i386/co mpile/custom_i386 i386 >Description: srv/sys/dev/puc/pucdata.c v1.51.2.3 adds support for 6-port Netmos cards to RELENG_6. The relevant PR is kern/58953. The commit breaks support for 4-port Netmos cards by incorrectly changing the "NetMos NM9845 Quad UART" puc_devices[] entry. This applies to v1.51.2.4 (RELENG_6) and v1.52.2.4.2.1 (RELENG_6_4) as well, which have the same entry. I could not confirm if the same behavior occurs in RELENG_6_4 or RELENG_6 due to lack of boxes running RELENG_6 or RELENG_6_4. >How-To-Repeat: Use RELENG_6_3 with a Netmos 4-port card and see puc(4) not attach. >Fix: The provided patch against src/sys/dev/puc/pucdata.c v1.51.2.3, taken from a post to freebsd-stable by Marcel Moolenaar on 2008-05-06, fixes the issue. The patch also succeeds against v1.51.2.4 and v1.51.2.4.2.1 with offset. Patch attached with submission follows: --- pucdata.c.orig 2006-12-15 14:31:37.000000000 -0800 +++ pucdata.c 2008-11-16 15:34:50.000000000 -0800 @@ -946,7 +946,7 @@ /* NetMos 4S0P PCI: 4S, 0P */ { "NetMos NM9845 Quad UART", - { 0x9710, 0x9845, 0, 0x0014 }, + { 0x9710, 0x9845, 0, 0x0004 }, { 0xffff, 0xffff, 0, 0xffff }, { { PUC_PORT_TYPE_COM, 0x10, 0x00, COM_FREQ }, >Release-Note: >Audit-Trail: >Unformatted: