From owner-cvs-src-old@FreeBSD.ORG Fri Mar 25 22:12:07 2011 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 50DDC106566C for ; Fri, 25 Mar 2011 22:12:07 +0000 (UTC) (envelope-from mdf@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 3EF208FC12 for ; Fri, 25 Mar 2011 22:12:07 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.4/8.14.4) with ESMTP id p2PMC737088844 for ; Fri, 25 Mar 2011 22:12:07 GMT (envelope-from mdf@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.4/8.14.4/Submit) id p2PMC72T088843 for cvs-src-old@freebsd.org; Fri, 25 Mar 2011 22:12:07 GMT (envelope-from mdf@repoman.freebsd.org) Message-Id: <201103252212.p2PMC72T088843@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to mdf@repoman.freebsd.org using -f From: Matthew D Fleming Date: Fri, 25 Mar 2011 22:11:39 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: RELENG_8 Subject: cvs commit: src/sys/kern kern_sysctl.c src/sys/sys sysctl.h X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Mar 2011 22:12:07 -0000 mdf 2011-03-25 22:11:39 UTC FreeBSD src repository Modified files: (Branch: RELENG_8) sys/kern kern_sysctl.c sys/sys sysctl.h Log: SVN rev 220011 on 2011-03-25 22:11:39Z by mdf MFC r216060. This differs from the original commit in that it preserves the KBI size of struct sysctl_oid. Also, on stable/8 the compiler thinks that 'len' in sysctl_sysctl_name2oid() is used uninitialized. Do not hold the sysctl lock across a call to the handler. This fixes a general LOR issue where the sysctl lock had no good place in the hierarchy. One specific instance is #284 on http://sources.zabbadoz.net/freebsd/lor.html . Revision Changes Path 1.201.2.4 +68 -28 src/sys/kern/kern_sysctl.c 1.176.2.5 +4 -2 src/sys/sys/sysctl.h