From owner-svn-src-head@freebsd.org Fri Apr 10 18:13:30 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0E9CE2C4EC4; Fri, 10 Apr 2020 18:13:30 +0000 (UTC) (envelope-from emaste@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48zR2x6jHwz4Ngg; Fri, 10 Apr 2020 18:13:29 +0000 (UTC) (envelope-from emaste@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id DBF462690; Fri, 10 Apr 2020 18:13:29 +0000 (UTC) (envelope-from emaste@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id 03AIDTZs071755; Fri, 10 Apr 2020 18:13:29 GMT (envelope-from emaste@FreeBSD.org) Received: (from emaste@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id 03AIDTdZ071754; Fri, 10 Apr 2020 18:13:29 GMT (envelope-from emaste@FreeBSD.org) Message-Id: <202004101813.03AIDTdZ071754@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: emaste set sender to emaste@FreeBSD.org using -f From: Ed Maste Date: Fri, 10 Apr 2020 18:13:29 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r359776 - head/sys/dev/sound/pci/hda X-SVN-Group: head X-SVN-Commit-Author: emaste X-SVN-Commit-Paths: head/sys/dev/sound/pci/hda X-SVN-Commit-Revision: 359776 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Apr 2020 18:13:30 -0000 Author: emaste Date: Fri Apr 10 18:13:29 2020 New Revision: 359776 URL: https://svnweb.freebsd.org/changeset/base/359776 Log: hdac: update comment on reset duration The comment previously stated the delay must be at least 250us but that was insufficient and so should be doubled, but the delay was actually 1000. The HDA spec actually says the delay must be 521 us (25 frames) so update the comment to match. Modified: head/sys/dev/sound/pci/hda/hdac.c Modified: head/sys/dev/sound/pci/hda/hdac.c ============================================================================== --- head/sys/dev/sound/pci/hda/hdac.c Fri Apr 10 16:27:27 2020 (r359775) +++ head/sys/dev/sound/pci/hda/hdac.c Fri Apr 10 18:13:29 2020 (r359776) @@ -440,9 +440,7 @@ hdac_reset(struct hdac_softc *sc, int wakeup) /* * Wait for codecs to finish their own reset sequence. The delay here - * should be of 250us but for some reasons, it's not enough on my - * computer. Let's use twice as much as necessary to make sure that - * it's reset properly. + * must be at least 521us (HDA 1.0a section 4.3 Codec Discovery). */ DELAY(1000);