From owner-freebsd-usb@FreeBSD.ORG  Mon Apr 21 23:51:07 2008
Return-Path: <owner-freebsd-usb@FreeBSD.ORG>
Delivered-To: freebsd-usb@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1E5E2106566B
	for <freebsd-usb@freebsd.org>; Mon, 21 Apr 2008 23:51:07 +0000 (UTC)
	(envelope-from markir@paradise.net.nz)
Received: from smtp4.clear.net.nz (smtp4.clear.net.nz [203.97.37.64])
	by mx1.freebsd.org (Postfix) with ESMTP id E46E58FC23
	for <freebsd-usb@freebsd.org>; Mon, 21 Apr 2008 23:51:06 +0000 (UTC)
	(envelope-from markir@paradise.net.nz)
Received: from zmori.markir.net
	(121-73-166-241.dsl.telstraclear.net [121.73.166.241])
	by smtp4.clear.net.nz (CLEAR Net Mail)
	with ESMTP id <0JZP00059877YL20@smtp4.clear.net.nz> for
	freebsd-usb@freebsd.org; Tue, 22 Apr 2008 11:35:34 +1200 (NZST)
Date: Tue, 22 Apr 2008 11:35:27 +1200
From: Mark Kirkwood <markir@paradise.net.nz>
In-reply-to: <20080421.060554.1621851987.imp@bsdimp.com>
To: "M. Warner Losh" <imp@bsdimp.com>
Message-id: <480D24BF.6080809@paradise.net.nz>
MIME-version: 1.0
Content-type: text/plain; charset=ISO-8859-1; format=flowed
Content-transfer-encoding: 7bit
References: <200804211030.m3LAU3Uo091913@freefall.freebsd.org>
	<20080421.060554.1621851987.imp@bsdimp.com>
User-Agent: Thunderbird 2.0.0.9 (X11/20080419)
Cc: freebsd-usb@freebsd.org
Subject: Re: usb/78984: [umass] [patch] Creative MUVO umass failure
X-BeenThere: freebsd-usb@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: FreeBSD support for USB <freebsd-usb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-usb>
List-Post: <mailto:freebsd-usb@freebsd.org>
List-Help: <mailto:freebsd-usb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Apr 2008 23:51:07 -0000

M. Warner Losh wrote:
> In message: <200804211030.m3LAU3Uo091913@freefall.freebsd.org>
>             Mark Kirkwood <markir@paradise.net.nz> writes:
> : The following reply was made to PR usb/78984; it has been noted by GNATS.
> : 
> : From: Mark Kirkwood <markir@paradise.net.nz>
> : To: bug-followup@FreeBSD.org, bofh@m-wesemeyer.de
> : Cc:  
> : Subject: Re: usb/78984: [umass] [patch] Creative MUVO umass failure
> : Date: Mon, 21 Apr 2008 22:11:17 +1200
> : 
> :  I ran into this with 7-STABLE and a 128MB creatiev muvo. This slightly 
> :  updated patch seems to fix.
> :  ================================================================================
> :  *** sys/dev/usb/umass.c.orig    Mon Apr 21 18:17:08 2008
> :  --- sys/dev/usb/umass.c Mon Apr 21 18:20:31 2008
> :  ***************
> :  *** 374,379 ****
> :  --- 374,383 ----
> :        UMASS_PROTO_SCSI | UMASS_PROTO_BBB,
> :        FORCE_SHORT_INQUIRY | NO_START_STOP | IGNORE_RESIDUE
> :      },
> :  +   { USB_VENDOR_CREATIVE, USB_PRODUCT_CREATIVE_NOMAD, RID_WILDCARD,
> :  +     UMASS_PROTO_SCSI | UMASS_PROTO_BBB,
> :  +     READ_CAPACITY_OFFBY1
> :  +   },
> :      { USB_VENDOR_DESKNOTE, USB_PRODUCT_DESKNOTE_UCR_61S2B, RID_WILDCARD,
> :        UMASS_PROTO_SCSI | UMASS_PROTO_BBB,
> :        NO_QUIRKS
> :  ================================================================================
>
> Are all Creative nomad's off by one?  In linux, this quirk is used
> extremely rarely, and i don't think I see the nomad on the lists...
>
>
>   

Good point, I think only the 128MB Nomad is the bad guy here - I guess I 
need to change RID_WILDCARD to whatever the id for the 128MB Nomad is (I 
see the original patch had 0x001 here) - assuming I've understood what 
RID_WILDCARD does correctly that is...

Cheers

Mark