From owner-cvs-usrsbin  Mon Oct 23 03:57:04 1995
Return-Path: owner-cvs-usrsbin
Received: (from root@localhost)
          by freefall.freebsd.org (8.6.12/8.6.6) id DAA02946
          for cvs-usrsbin-outgoing; Mon, 23 Oct 1995 03:57:04 -0700
Received: from jhome.DIALix.COM (root@jhome.DIALix.COM [192.203.228.69])
          by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id DAA02871
          ; Mon, 23 Oct 1995 03:55:17 -0700
Received: (from peter@localhost) by jhome.DIALix.COM (8.6.12/8.6.9) id SAA10840; Mon, 23 Oct 1995 18:55:02 +0800
Date: Mon, 23 Oct 1995 18:55:01 +0800 (WST)
From: Peter Wemm <peter@jhome.DIALix.COM>
To: David Greenman <davidg@freefall.freebsd.org>
cc: CVS-commiters@freefall.freebsd.org, cvs-usrsbin@freefall.freebsd.org
Subject: Re: cvs commit: src/usr.sbin/config mkmakefile.c
In-Reply-To: <199510231029.DAA02147@freefall.freebsd.org>
Message-ID: <Pine.BSF.3.91.951023185233.5332N-100000@jhome.DIALix.COM>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-usrsbin@FreeBSD.org
Precedence: bulk

On Mon, 23 Oct 1995, David Greenman wrote:
> 
> davidg      95/10/23 03:29:17
> 
>   Modified:    usr.sbin/config  mkmakefile.c
>   Log:
>   Don't pre-processor define 'ident'. This has subtle consequences for people
>   who don't carefully consider their choice for the machine name. The same
>   functionality can still be had with an "option", so nothing is lost.

I saw a couple of
#ifdef GENERIC /* compiling for generic kernel */
....
#endif
around the place some time ago.  Are these gone too?

If this functionality is needed, perhaps it'd be better to change it to 
CONFIG_<ident> instead?  ie: #ifdef CONFIG_GENERIC instead?

-Peter