From owner-svn-src-head@freebsd.org Tue Oct 8 12:52:14 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B3A9114747F; Tue, 8 Oct 2019 12:52:14 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [88.99.82.50]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46ncgd6hY3z3PT0; Tue, 8 Oct 2019 12:52:13 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2016.home.selasky.org (unknown [62.141.129.235]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 111682600F8; Tue, 8 Oct 2019 14:52:10 +0200 (CEST) Subject: Re: svn commit: r353274 - in head/sys: net sys To: "Bjoern A. Zeeb" Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201910071415.x97EFfiN064058@repo.freebsd.org> From: Hans Petter Selasky Message-ID: <41bf4178-689e-573c-2684-450ee02d8de4@selasky.org> Date: Tue, 8 Oct 2019 14:50:46 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 46ncgd6hY3z3PT0 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of hps@selasky.org designates 88.99.82.50 as permitted sender) smtp.mailfrom=hps@selasky.org X-Spamd-Result: default: False [-5.48 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+a:mail.turbocat.net]; FROM_HAS_DN(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[selasky.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; IP_SCORE(-3.18)[ip: (-9.36), ipnet: 88.99.0.0/16(-4.75), asn: 24940(-1.81), country: DE(-0.01)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:88.99.0.0/16, country:DE]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Oct 2019 12:52:14 -0000 On 2019-10-08 14:48, Bjoern A. Zeeb wrote: > On 7 Oct 2019, at 14:15, Hans Petter Selasky wrote: > >> Author: hselasky >> Date: Mon Oct  7 14:15:41 2019 >> New Revision: 353274 >> URL: https://svnweb.freebsd.org/changeset/base/353274 >> >> Log: >>   Factor out VNET shutdown check into an own vnet structure field. >>   Remove the now obsolete vnet_state field. This greatly simplifies the >>   detection of VNET shutdown and avoids code duplication. > > I think I tried to say that the vnet_state is extremely helpful for > debugging as you know where each of the stacks is during > initialisation/shutdown, especially with loadable  modules and that it > should stay and I cannot remember that I removed it in the patch that I > suggested. > > I didn’t re-used a field but extended the structure.  What you did means > you cannot MFC this easily.  Also it means that all previous vnet > consumers got invalidated and the VNET_MAGIC_N should have been bumped > and all modules need a re-compile. > > OK I can fix that, but should VNET_MAGIC_N be bumped when adding the new vnet_shutdown boolean to this structure? --HPS