From owner-p4-projects@FreeBSD.ORG  Fri Oct 14 14:49:42 2011
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 082DD1065672; Fri, 14 Oct 2011 14:49:42 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B5A7B106564A
	for <perforce@freebsd.org>; Fri, 14 Oct 2011 14:49:41 +0000 (UTC)
	(envelope-from jhb@freebsd.org)
Received: from skunkworks.freebsd.org (skunkworks.freebsd.org
	[IPv6:2001:4f8:fff6::2d])
	by mx1.freebsd.org (Postfix) with ESMTP id A26618FC13
	for <perforce@freebsd.org>; Fri, 14 Oct 2011 14:49:41 +0000 (UTC)
Received: from skunkworks.freebsd.org (localhost [127.0.0.1])
	by skunkworks.freebsd.org (8.14.4/8.14.4) with ESMTP id p9EEnf0T068187
	for <perforce@freebsd.org>; Fri, 14 Oct 2011 14:49:41 GMT
	(envelope-from jhb@freebsd.org)
Received: (from perforce@localhost)
	by skunkworks.freebsd.org (8.14.4/8.14.4/Submit) id p9EEnfD4068184
	for perforce@freebsd.org; Fri, 14 Oct 2011 14:49:41 GMT
	(envelope-from jhb@freebsd.org)
Date: Fri, 14 Oct 2011 14:49:41 GMT
Message-Id: <201110141449.p9EEnfD4068184@skunkworks.freebsd.org>
X-Authentication-Warning: skunkworks.freebsd.org: perforce set sender to
	jhb@freebsd.org using -f
From: John Baldwin <jhb@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Precedence: bulk
Cc: 
Subject: PERFORCE change 200200 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Oct 2011 14:49:42 -0000

http://p4web.freebsd.org/@@200200?ac=10

Change 200200 by jhb@jhb_jhbbsd on 2011/10/14 14:49:12

	Note unexpected behavior.

Affected files ...

.. //depot/projects/fadvise/sys/kern/vfs_syscalls.c#5 edit

Differences ...

==== //depot/projects/fadvise/sys/kern/vfs_syscalls.c#5 (text+ko) ====

@@ -4946,6 +4946,9 @@
 		 * Apply the request to the backing VM object.  Note
 		 * that the FADV_* constants map directly to the same
 		 * madvise(2) constants.
+		 *
+		 * XXX: madvise(MADV_WILLNEED) will not do readahead on
+		 * a file, perhaps FADV_WILLNEED should.
 		 */
 		start = trunc_page(uap->offset);
 		end = round_page(end);