Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 14 Oct 2011 14:49:41 GMT
From:      John Baldwin <jhb@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 200200 for review
Message-ID:  <201110141449.p9EEnfD4068184@skunkworks.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://p4web.freebsd.org/@@200200?ac=10

Change 200200 by jhb@jhb_jhbbsd on 2011/10/14 14:49:12

	Note unexpected behavior.

Affected files ...

.. //depot/projects/fadvise/sys/kern/vfs_syscalls.c#5 edit

Differences ...

==== //depot/projects/fadvise/sys/kern/vfs_syscalls.c#5 (text+ko) ====

@@ -4946,6 +4946,9 @@
 		 * Apply the request to the backing VM object.  Note
 		 * that the FADV_* constants map directly to the same
 		 * madvise(2) constants.
+		 *
+		 * XXX: madvise(MADV_WILLNEED) will not do readahead on
+		 * a file, perhaps FADV_WILLNEED should.
 		 */
 		start = trunc_page(uap->offset);
 		end = round_page(end);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201110141449.p9EEnfD4068184>