From owner-svn-src-head@freebsd.org Sun Feb 12 15:42:06 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 55744CDB3F2; Sun, 12 Feb 2017 15:42:06 +0000 (UTC) (envelope-from gnn@neville-neil.com) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [IPv6:2001:4b98:c:538::198]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 07FC71673; Sun, 12 Feb 2017 15:42:05 +0000 (UTC) (envelope-from gnn@neville-neil.com) Received: from mfilter15-d.gandi.net (mfilter15-d.gandi.net [217.70.178.143]) by relay6-d.mail.gandi.net (Postfix) with ESMTP id 4F3D1FB886; Sun, 12 Feb 2017 16:42:03 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mfilter15-d.gandi.net Received: from relay6-d.mail.gandi.net ([IPv6:::ffff:217.70.183.198]) by mfilter15-d.gandi.net (mfilter15-d.gandi.net [::ffff:10.0.15.180]) (amavisd-new, port 10024) with ESMTP id Mfv9Ns1a40s1; Sun, 12 Feb 2017 16:42:01 +0100 (CET) X-Originating-IP: 108.29.111.63 Received: from [172.16.19.1] (pool-108-29-111-63.nycmny.fios.verizon.net [108.29.111.63]) (Authenticated sender: gnn@neville-neil.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id A74CCFB881; Sun, 12 Feb 2017 16:42:00 +0100 (CET) From: "George Neville-Neil" To: "Glen Barber" Cc: "Ermal =?utf-8?q?Lu=C3=A7i?=" , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r313675 - in head/sys: netinet netinet6 Date: Sun, 12 Feb 2017 10:41:58 -0500 Message-ID: <53D3A92C-6C64-4C0C-A5E6-B659BFA139BF@neville-neil.com> In-Reply-To: <20170212111045.GC13738@FreeBSD.org> References: <201702120656.v1C6uXp1008956@repo.freebsd.org> <20170212111045.GC13738@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=_MailMate_399D2B93-4FB8-4736-9FAB-586EA5CE5549_="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Mailer: MailMate (1.9.6r5344) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Feb 2017 15:42:06 -0000 This is an OpenPGP/MIME signed message (RFC 3156 and 4880). --=_MailMate_399D2B93-4FB8-4736-9FAB-586EA5CE5549_= Content-Type: text/plain; charset=utf-8; markup=markdown Content-Transfer-Encoding: quoted-printable On 12 Feb 2017, at 6:10, Glen Barber wrote: > On Sun, Feb 12, 2017 at 06:56:33AM +0000, Ermal Lu=C3=A7i wrote: >> Author: eri >> Date: Sun Feb 12 06:56:33 2017 >> New Revision: 313675 >> URL: https://svnweb.freebsd.org/changeset/base/313675 >> >> Log: >> Committed without approval from mentor. >> >> Reported by: gnn >> > > What exactly does this mean? > Ermal took the Acceptance on reviews.freebsd.org by Adrian as an implicit= "go ahead" to commit to the tree. The issue is that he's still under me= ntorship, by me, and had not gotten an approval or had an Approved by: li= ne. I asked him to revert the change himself. We're working out a few more issues in the review now. Best, George --=_MailMate_399D2B93-4FB8-4736-9FAB-586EA5CE5549_= Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- Comment: GPGTools - http://gpgtools.org iEYEARECAAYFAliggkcACgkQYdh2wUQKM9LuOgCfbTTUz83s0WuLQLvudd+UvnPr NfUAmwWaYVBc8oPnsEmZe8mK2sKuyLGe =ixfM -----END PGP SIGNATURE----- --=_MailMate_399D2B93-4FB8-4736-9FAB-586EA5CE5549_=--