Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 13 Apr 2022 00:02:13 GMT
From:      John Baldwin <jhb@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: c0a42a04513d - main - ix: Remove cpu_id and related code from ixgbe_if_msix_intr_assign.
Message-ID:  <202204130002.23D02D2p010361@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by jhb:

URL: https://cgit.FreeBSD.org/src/commit/?id=c0a42a04513de99fc02b30a88a6de0f85cf644db

commit c0a42a04513de99fc02b30a88a6de0f85cf644db
Author:     John Baldwin <jhb@FreeBSD.org>
AuthorDate: 2022-04-13 00:01:46 +0000
Commit:     John Baldwin <jhb@FreeBSD.org>
CommitDate: 2022-04-13 00:01:46 +0000

    ix: Remove cpu_id and related code from ixgbe_if_msix_intr_assign.
    
    Reviewed by:    erj
    Differential Revision:  https://reviews.freebsd.org/D34828
---
 sys/dev/ixgbe/if_ix.c | 20 --------------------
 1 file changed, 20 deletions(-)

diff --git a/sys/dev/ixgbe/if_ix.c b/sys/dev/ixgbe/if_ix.c
index 3077fc9ac4f8..4e34a1b12302 100644
--- a/sys/dev/ixgbe/if_ix.c
+++ b/sys/dev/ixgbe/if_ix.c
@@ -2075,7 +2075,6 @@ ixgbe_if_msix_intr_assign(if_ctx_t ctx, int msix)
 	struct ix_rx_queue *rx_que = sc->rx_queues;
 	struct ix_tx_queue *tx_que;
 	int                error, rid, vector = 0;
-	int                cpu_id = 0;
 	char               buf[16];
 
 	/* Admin Que is vector 0*/
@@ -2095,25 +2094,6 @@ ixgbe_if_msix_intr_assign(if_ctx_t ctx, int msix)
 		}
 
 		rx_que->msix = vector;
-		if (sc->feat_en & IXGBE_FEATURE_RSS) {
-			/*
-			 * The queue ID is used as the RSS layer bucket ID.
-			 * We look up the queue ID -> RSS CPU ID and select
-			 * that.
-			 */
-			cpu_id = rss_getcpu(i % rss_getnumbuckets());
-		} else {
-			/*
-			 * Bind the MSI-X vector, and thus the
-			 * rings to the corresponding cpu.
-			 *
-			 * This just happens to match the default RSS
-			 * round-robin bucket -> queue -> CPU allocation.
-			 */
-			if (sc->num_rx_queues > 1)
-				cpu_id = i;
-		}
-
 	}
 	for (int i = 0; i < sc->num_tx_queues; i++) {
 		snprintf(buf, sizeof(buf), "txq%d", i);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202204130002.23D02D2p010361>