From owner-freebsd-current@FreeBSD.ORG  Sun Feb 24 19:41:22 2013
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id EEB5B50F;
 Sun, 24 Feb 2013 19:41:22 +0000 (UTC)
 (envelope-from pluknet@gmail.com)
Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com
 [209.85.212.176]) by mx1.freebsd.org (Postfix) with ESMTP id 551337F;
 Sun, 24 Feb 2013 19:41:22 +0000 (UTC)
Received: by mail-wi0-f176.google.com with SMTP id hm14so2652005wib.9
 for <multiple recipients>; Sun, 24 Feb 2013 11:41:21 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:x-received:sender:in-reply-to:references:date
 :x-google-sender-auth:message-id:subject:from:to:cc:content-type;
 bh=M84IDsw1C3g7fjoROU11vs5qyZUZmMgaAt/SfB+6ka8=;
 b=jVO1oW8/OCRBbdq8c8bYIGWAqXWnqN1SMAY4IZnxuBKHoPOuMlIp9gSA5NEZ+ihyFy
 B3yWblSnTRnAmTCWVPTTwWpzVbziLFaKfG2IepK9yQkAHCMlwY3M6CKNp4hbmJ7AnFgq
 gW8/tyVyo3HzceFFtoXQAGMPn8D4AKQPO2UTryjTxJpX3LvZKoPpCu4wsMCJ7khavyJq
 g37j9F7ZHxSwvInbmt8q2qmGobh8QhTkefJgRW6uUID6inbrxSQM3px1BY6wB4pHkmEC
 NJ30UTK2C3Mvd0Tl/ZOzg9fkkuodcElVNBIU0t4MppVv6PDQrSmdBNm6Fkq88XLp1mYF
 zOQg==
MIME-Version: 1.0
X-Received: by 10.194.242.69 with SMTP id wo5mr14784115wjc.10.1361734881227;
 Sun, 24 Feb 2013 11:41:21 -0800 (PST)
Sender: pluknet@gmail.com
Received: by 10.194.86.167 with HTTP; Sun, 24 Feb 2013 11:41:21 -0800 (PST)
In-Reply-To: <20130224152552.GB2785@albert.catwhisker.org>
References: <20130224150534.GA2785@albert.catwhisker.org>
 <20130224152552.GB2785@albert.catwhisker.org>
Date: Sun, 24 Feb 2013 22:41:21 +0300
X-Google-Sender-Auth: CMxsDwuo1oOXA5mYZhKDto2uSKo
Message-ID: <CAE-mSOJGUjwpQC-Nw_ZrpLA_YK_aQBzQSYeKTCVeaMOEbK0XrA@mail.gmail.com>
Subject: Re: [PATCH] Fix sbin/fsdb/fsdbutil.c for r247212
From: Sergey Kandaurov <pluknet@freebsd.org>
To: David Wolfskill <david@catwhisker.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: current@freebsd.org, Kirk McKusick <mckusick@freebsd.org>
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 24 Feb 2013 19:41:23 -0000

On 24 February 2013 19:25, David Wolfskill <david@catwhisker.org> wrote:
> On Sun, Feb 24, 2013 at 07:05:34AM -0800, David Wolfskill wrote:
>> ...hine was:
>> Simple patch attached; world is still building, but at least it got
>> through the "make dependencies" phase this time.
>> ...
>
> That was incomplete, as it didn't (also) address the change to
> getdatablk().
>
> The attached patch actually made it through buildworld.
>
> Note that it is entirely possible that I erred in specifying
> "BT_UNKNOWN" for the additional "type" argument.

Hi David.

Thank you for the proposed fix. I committed it with r247234.
I'm not sure regarding BT_UNKNOWN value either. Well..  at least
it should be not worse that it is now, and it should fix the build.
I have not found any (regressive) changes in fsdb -d `blocks' output.

-- 
wbr,
pluknet